linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: wim@iguana.be (Wim Van Sebroeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] Driver for the watchdog timer on Freescale IMX2 (and later) processors.
Date: Tue, 25 May 2010 13:06:44 +0200	[thread overview]
Message-ID: <20100525110644.GA3972@infomag.iguana.be> (raw)
In-Reply-To: <20100525102629.GB25521@pengutronix.de>

Hi Wolfram,

> > > > #define WDOG_SEC_TO_COUNT(s)	((s * 2) << 8)
> > > 
> > > Any reason you dropped the '- 1' from my version here?
> > 
> > If you want a timeout of 1 second, and you subtract the -1 then you only get
> > 0.5 seconds according to the reference manual.
> 
> Which one? MX27 and MX31 refman say the range is 0.5 to 128 seconds.
> So, 0x00 = 0.5s, 0x01 = 1.0s... The MX35 refman even has a table confirming this.

My fault. I interpreted it incorrectly. if you have 128 seconds then you indeed have value 0xFF << 8...
so -1 should indeed be there. This make the macro:
#define WDOG_SEC_TO_COUNT(s)	(((s * 2) - 1) << 8)

Thanks,
Wim.

  reply	other threads:[~2010-05-25 11:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-29  8:03 IMX Watchdog driver for machs MX2 up to MX51 Wolfram Sang
2010-04-29  8:03 ` [PATCH 1/6] Driver for the watchdog timer on Freescale IMX2 (and later) processors Wolfram Sang
2010-05-14  2:49   ` Wolfram Sang
2010-05-14 15:56     ` Wim Van Sebroeck
2010-05-17  9:50       ` Sascha Hauer
2010-05-21 21:52     ` Wim Van Sebroeck
2010-05-25  9:18       ` Wolfram Sang
2010-05-25 10:12         ` Wim Van Sebroeck
2010-05-25 10:26           ` Wolfram Sang
2010-05-25 11:06             ` Wim Van Sebroeck [this message]
2010-04-29  8:03 ` [PATCH 2/6] arm/mach-mx2/3: Fix watchdog-devices to match the current driver Wolfram Sang
2010-05-17  9:51   ` Sascha Hauer
2010-04-29  8:03 ` [PATCH 3/6] arm/mach-mx3: add watchdog device to Phytec-boards Wolfram Sang
2010-05-17  9:51   ` Sascha Hauer
2010-04-29  8:03 ` [PATCH 4/6] arm/mach-mx2: " Wolfram Sang
2010-04-29  8:03 ` [PATCH 5/6] arm/mx25: add watchdog device Wolfram Sang
2010-05-06 10:21   ` Juergen Beisert
2010-05-17  9:49   ` Sascha Hauer
2010-05-17 10:33     ` [PATCH V2 " Wolfram Sang
2010-05-17 10:33     ` [PATCH V2 6/6] arm/mx51: " Wolfram Sang
2010-04-29  8:03 ` [PATCH " Wolfram Sang
2010-04-29  8:24 ` IMX Watchdog driver for machs MX2 up to MX51 Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100525110644.GA3972@infomag.iguana.be \
    --to=wim@iguana.be \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).