From: hjk@linutronix.de (Hans J. Koch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7 v5] Add the clock framework for Telechips TCC8xxx processors.
Date: Wed, 26 May 2010 19:31:11 +0200 [thread overview]
Message-ID: <20100526173111.GB2006@bluebox.local> (raw)
In-Reply-To: <20100422111917.GE20008@n2100.arm.linux.org.uk>
On Thu, Apr 22, 2010 at 12:19:17PM +0100, Russell King - ARM Linux wrote:
> On Wed, Apr 21, 2010 at 02:42:01PM +0200, Hans J. Koch wrote:
> > +static int __set_parent(struct clk *clock, struct clk *parent)
> > +{
> > + if (clock->parent && (clock->parent != parent)) {
> > + clock->parent->refcount--;
> > + if ((clock->parent->refcount == 0) && clock->parent->disable)
> > + clock->parent->disable(clock->parent);
> > + }
> > +
> > + clock->parent = parent;
> > + if (clock->parent)
> > + clock->parent->refcount++;
>
> Is this left over from the old clk_set_parent() implementation - with
> the handling of refcounting in the main clk_set_parent(), this refcounting
> seems unnecessary (and seems buggy.)
Right. All refcounting is already done in plat-tcc/clock.c, so this
__set_parent() became obsolete. I removed it completely, because the initial
parent setting is already done elsewhere.
Thanks,
Hans
next prev parent reply other threads:[~2010-05-26 17:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 12:38 [PATCH 0/7 v5] Add basic support for Telechips TCC8xxx SoCs Hans J. Koch
2010-04-21 12:40 ` [PATCH 1/7 v5] Introduce plat-tcc Hans J. Koch
[not found] ` <20100422111007.GD20008@n2100.arm.linux.org.uk>
2010-05-26 17:28 ` Hans J. Koch
2010-04-21 12:42 ` [PATCH 2/7 v5] Add the clock framework for Telechips TCC8xxx processors Hans J. Koch
[not found] ` <20100422111917.GE20008@n2100.arm.linux.org.uk>
2010-05-26 17:31 ` Hans J. Koch [this message]
2010-04-21 12:43 ` [PATCH 3/7 v5] Introduce plat-tcc irq framework Hans J. Koch
2010-04-21 12:44 ` [PATCH 4/7 v5] Add TCC8xxx system timer Hans J. Koch
2010-04-21 12:45 ` [PATCH 5/7 v5] Basic IO mappings for mach-tcc8k Hans J. Koch
2010-04-21 12:46 ` [PATCH 6/7 v5] Add common platform devices for TCC8xxx SoCs Hans J. Koch
2010-04-21 12:47 ` [PATCH 7/7 v5] Add board support for Telechips TCC8000-SDK board Hans J. Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526173111.GB2006@bluebox.local \
--to=hjk@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).