linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM:VFPv3:enable {d16-d31} access
Date: Wed, 26 May 2010 21:10:17 +0100	[thread overview]
Message-ID: <20100526201017.GE6232@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB0322FA8E37@dbde02.ent.ti.com>

On Wed, May 26, 2010 at 05:13:24PM +0530, DebBarma, Tarun Kanti wrote:
> 1) With the existing implementation I am not able to correctly
> write/read {d0-d15} but not the {d16-d31} set
> 
> 2) With my changes I am able to write/read correctly.

The reason this happens is simple.  In vfp_get_double(), we have:

1:      fmrrd   r0, r1, d\dr
1:      mrrc    p11, 3, r0, r1, c\dr    @ fmrrd r0, r1, d\dr

but in vfp_put_double(), we have:

1:      fmdrr   d\dr, r0, r1
1:      mcrr    p11, 3, r1, r2, c\dr    @ fmdrr r1, r2, d\dr

Note the different registers.  Change "r1, r2" to "r0, r1" and it
should work.

  reply	other threads:[~2010-05-26 20:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Tarun Kanti DebBarma <tarun.kanti@ti.com>
     [not found] ` <1274818736-26597-1-git-send-email-tarun.kanti@ti.com>
2010-05-25  9:09   ` [PATCH] ARM:VFPv3:enable {d16-d31} access DebBarma, Tarun Kanti
2010-05-25 12:26     ` Siarhei Siamashka
2010-05-25 15:43       ` DebBarma, Tarun Kanti
2010-05-25 18:57     ` Russell King - ARM Linux
2010-05-26 11:43       ` DebBarma, Tarun Kanti
2010-05-26 20:10         ` Russell King - ARM Linux [this message]
2010-05-27  4:37           ` DebBarma, Tarun Kanti
2010-05-27  9:29             ` Russell King - ARM Linux
2010-05-27  9:31               ` DebBarma, Tarun Kanti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100526201017.GE6232@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).