From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/17] arch/arm/common: Add missing spin_unlock_irqrestore
Date: Wed, 26 May 2010 21:13:37 +0200 [thread overview]
Message-ID: <201005262113.38450.marek.vasut@gmail.com> (raw)
In-Reply-To: <20100526184358.GC6232@n2100.arm.linux.org.uk>
Dne St 26. kv?tna 2010 20:43:58 Russell King - ARM Linux napsal(a):
> On Wed, May 26, 2010 at 07:07:06PM +0200, Marek Vasut wrote:
> > Why are "readl"s protected by spinlock anyway ? Can't we just move the
> > locking past the code above ?
>
> Good question - and there seems to be a deadlock waiting to happen -
> sa1111_wake() re-takes the same lock.
>
> I think we should kill all the spinlock in sa1111_resume().
Russell, Julia, check the patch I posted. Comments are welcome.
btw. Russell, killing the spinlock in resume might be overkill. If there was any
reason for that being there, it was for the write ops so I'd rather keep those
locked. Anyone with actual hardware available should look into that though.
prev parent reply other threads:[~2010-05-26 19:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 15:56 [PATCH 7/17] arch/arm/common: Add missing spin_unlock_irqrestore Julia Lawall
2010-05-26 17:07 ` Marek Vasut
2010-05-26 18:43 ` Russell King - ARM Linux
2010-05-26 19:13 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005262113.38450.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).