* [PATCH] ARM: S5PV210: serial: Fix section mismatch warning
@ 2010-05-28 10:21 Joonyoung Shim
2010-05-28 10:27 ` Ben Dooks
2010-05-28 10:29 ` Ben Dooks
0 siblings, 2 replies; 4+ messages in thread
From: Joonyoung Shim @ 2010-05-28 10:21 UTC (permalink / raw)
To: linux-arm-kernel
Rename the structure to avoid the following warning:
WARNING: drivers/serial/built-in.o(.data+0x534): Section mismatch in reference from the variable s5p_serial_drv to the function .devexit.text:s3c24xx_serial_remove()
The variable s5p_serial_drv references
the function __devexit s3c24xx_serial_remove()
If the reference is valid then annotate the
variable with __exit* (see linux/init.h) or name the variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
drivers/serial/s5pv210.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/serial/s5pv210.c b/drivers/serial/s5pv210.c
index 8dc0383..4a789e5 100644
--- a/drivers/serial/s5pv210.c
+++ b/drivers/serial/s5pv210.c
@@ -119,7 +119,7 @@ static int s5p_serial_probe(struct platform_device *pdev)
return s3c24xx_serial_probe(pdev, s5p_uart_inf[pdev->id]);
}
-static struct platform_driver s5p_serial_drv = {
+static struct platform_driver s5p_serial_driver = {
.probe = s5p_serial_probe,
.remove = __devexit_p(s3c24xx_serial_remove),
.driver = {
@@ -130,19 +130,19 @@ static struct platform_driver s5p_serial_drv = {
static int __init s5pv210_serial_console_init(void)
{
- return s3c24xx_serial_initconsole(&s5p_serial_drv, s5p_uart_inf);
+ return s3c24xx_serial_initconsole(&s5p_serial_driver, s5p_uart_inf);
}
console_initcall(s5pv210_serial_console_init);
static int __init s5p_serial_init(void)
{
- return s3c24xx_serial_init(&s5p_serial_drv, *s5p_uart_inf);
+ return s3c24xx_serial_init(&s5p_serial_driver, *s5p_uart_inf);
}
static void __exit s5p_serial_exit(void)
{
- platform_driver_unregister(&s5p_serial_drv);
+ platform_driver_unregister(&s5p_serial_driver);
}
module_init(s5p_serial_init);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: S5PV210: serial: Fix section mismatch warning
2010-05-28 10:21 [PATCH] ARM: S5PV210: serial: Fix section mismatch warning Joonyoung Shim
@ 2010-05-28 10:27 ` Ben Dooks
2010-05-28 10:29 ` Ben Dooks
1 sibling, 0 replies; 4+ messages in thread
From: Ben Dooks @ 2010-05-28 10:27 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 28, 2010 at 07:21:11PM +0900, Joonyoung Shim wrote:
> Rename the structure to avoid the following warning:
ok, will apply to next fixes tree.
> WARNING: drivers/serial/built-in.o(.data+0x534): Section mismatch in reference from the variable s5p_serial_drv to the function .devexit.text:s3c24xx_serial_remove()
> The variable s5p_serial_drv references
> the function __devexit s3c24xx_serial_remove()
> If the reference is valid then annotate the
> variable with __exit* (see linux/init.h) or name the variable:
> *driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> drivers/serial/s5pv210.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/serial/s5pv210.c b/drivers/serial/s5pv210.c
> index 8dc0383..4a789e5 100644
> --- a/drivers/serial/s5pv210.c
> +++ b/drivers/serial/s5pv210.c
> @@ -119,7 +119,7 @@ static int s5p_serial_probe(struct platform_device *pdev)
> return s3c24xx_serial_probe(pdev, s5p_uart_inf[pdev->id]);
> }
>
> -static struct platform_driver s5p_serial_drv = {
> +static struct platform_driver s5p_serial_driver = {
> .probe = s5p_serial_probe,
> .remove = __devexit_p(s3c24xx_serial_remove),
> .driver = {
> @@ -130,19 +130,19 @@ static struct platform_driver s5p_serial_drv = {
>
> static int __init s5pv210_serial_console_init(void)
> {
> - return s3c24xx_serial_initconsole(&s5p_serial_drv, s5p_uart_inf);
> + return s3c24xx_serial_initconsole(&s5p_serial_driver, s5p_uart_inf);
> }
>
> console_initcall(s5pv210_serial_console_init);
>
> static int __init s5p_serial_init(void)
> {
> - return s3c24xx_serial_init(&s5p_serial_drv, *s5p_uart_inf);
> + return s3c24xx_serial_init(&s5p_serial_driver, *s5p_uart_inf);
> }
>
> static void __exit s5p_serial_exit(void)
> {
> - platform_driver_unregister(&s5p_serial_drv);
> + platform_driver_unregister(&s5p_serial_driver);
> }
>
> module_init(s5p_serial_init);
> --
> 1.7.0.4
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: S5PV210: serial: Fix section mismatch warning
2010-05-28 10:21 [PATCH] ARM: S5PV210: serial: Fix section mismatch warning Joonyoung Shim
2010-05-28 10:27 ` Ben Dooks
@ 2010-05-28 10:29 ` Ben Dooks
2010-05-28 10:36 ` Joonyoung Shim
1 sibling, 1 reply; 4+ messages in thread
From: Ben Dooks @ 2010-05-28 10:29 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 28, 2010 at 07:21:11PM +0900, Joonyoung Shim wrote:
> Rename the structure to avoid the following warning:
>
> WARNING: drivers/serial/built-in.o(.data+0x534): Section mismatch in reference from the variable s5p_serial_drv to the function .devexit.text:s3c24xx_serial_remove()
> The variable s5p_serial_drv references
> the function __devexit s3c24xx_serial_remove()
> If the reference is valid then annotate the
> variable with __exit* (see linux/init.h) or name the variable:
> *driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
if it's from you, then why is there a signoff from marek.
if Marek is the original authour then there should be a "From:" line
attributing the patch to him.
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> drivers/serial/s5pv210.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/serial/s5pv210.c b/drivers/serial/s5pv210.c
> index 8dc0383..4a789e5 100644
> --- a/drivers/serial/s5pv210.c
> +++ b/drivers/serial/s5pv210.c
> @@ -119,7 +119,7 @@ static int s5p_serial_probe(struct platform_device *pdev)
> return s3c24xx_serial_probe(pdev, s5p_uart_inf[pdev->id]);
> }
>
> -static struct platform_driver s5p_serial_drv = {
> +static struct platform_driver s5p_serial_driver = {
> .probe = s5p_serial_probe,
> .remove = __devexit_p(s3c24xx_serial_remove),
> .driver = {
> @@ -130,19 +130,19 @@ static struct platform_driver s5p_serial_drv = {
>
> static int __init s5pv210_serial_console_init(void)
> {
> - return s3c24xx_serial_initconsole(&s5p_serial_drv, s5p_uart_inf);
> + return s3c24xx_serial_initconsole(&s5p_serial_driver, s5p_uart_inf);
> }
>
> console_initcall(s5pv210_serial_console_init);
>
> static int __init s5p_serial_init(void)
> {
> - return s3c24xx_serial_init(&s5p_serial_drv, *s5p_uart_inf);
> + return s3c24xx_serial_init(&s5p_serial_driver, *s5p_uart_inf);
> }
>
> static void __exit s5p_serial_exit(void)
> {
> - platform_driver_unregister(&s5p_serial_drv);
> + platform_driver_unregister(&s5p_serial_driver);
> }
>
> module_init(s5p_serial_init);
> --
> 1.7.0.4
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: S5PV210: serial: Fix section mismatch warning
2010-05-28 10:29 ` Ben Dooks
@ 2010-05-28 10:36 ` Joonyoung Shim
0 siblings, 0 replies; 4+ messages in thread
From: Joonyoung Shim @ 2010-05-28 10:36 UTC (permalink / raw)
To: linux-arm-kernel
On 5/28/2010 7:29 PM, Ben Dooks wrote:
> On Fri, May 28, 2010 at 07:21:11PM +0900, Joonyoung Shim wrote:
>> Rename the structure to avoid the following warning:
>>
>> WARNING: drivers/serial/built-in.o(.data+0x534): Section mismatch in reference from the variable s5p_serial_drv to the function .devexit.text:s3c24xx_serial_remove()
>> The variable s5p_serial_drv references
>> the function __devexit s3c24xx_serial_remove()
>> If the reference is valid then annotate the
>> variable with __exit* (see linux/init.h) or name the variable:
>> *driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> if it's from you, then why is there a signoff from marek.
>
> if Marek is the original authour then there should be a "From:" line
> attributing the patch to him.
>
OK. Marek is the original author.
From: Marek Szyprowski <m.szyprowski@samsung.com>
Rename the structure to avoid the following warning:
WARNING: drivers/serial/built-in.o(.data+0x534): Section mismatch in reference from the variable s5p_serial_drv to the function .devexit.text:s3c24xx_serial_remove()
The variable s5p_serial_drv references
the function __devexit s3c24xx_serial_remove()
If the reference is valid then annotate the
variable with __exit* (see linux/init.h) or name the variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
drivers/serial/s5pv210.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/serial/s5pv210.c b/drivers/serial/s5pv210.c
index 8dc0383..4a789e5 100644
--- a/drivers/serial/s5pv210.c
+++ b/drivers/serial/s5pv210.c
@@ -119,7 +119,7 @@ static int s5p_serial_probe(struct platform_device *pdev)
return s3c24xx_serial_probe(pdev, s5p_uart_inf[pdev->id]);
}
-static struct platform_driver s5p_serial_drv = {
+static struct platform_driver s5p_serial_driver = {
.probe = s5p_serial_probe,
.remove = __devexit_p(s3c24xx_serial_remove),
.driver = {
@@ -130,19 +130,19 @@ static struct platform_driver s5p_serial_drv = {
static int __init s5pv210_serial_console_init(void)
{
- return s3c24xx_serial_initconsole(&s5p_serial_drv, s5p_uart_inf);
+ return s3c24xx_serial_initconsole(&s5p_serial_driver, s5p_uart_inf);
}
console_initcall(s5pv210_serial_console_init);
static int __init s5p_serial_init(void)
{
- return s3c24xx_serial_init(&s5p_serial_drv, *s5p_uart_inf);
+ return s3c24xx_serial_init(&s5p_serial_driver, *s5p_uart_inf);
}
static void __exit s5p_serial_exit(void)
{
- platform_driver_unregister(&s5p_serial_drv);
+ platform_driver_unregister(&s5p_serial_driver);
}
module_init(s5p_serial_init);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-05-28 10:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-28 10:21 [PATCH] ARM: S5PV210: serial: Fix section mismatch warning Joonyoung Shim
2010-05-28 10:27 ` Ben Dooks
2010-05-28 10:29 ` Ben Dooks
2010-05-28 10:36 ` Joonyoung Shim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox