From: avorontsov@mvista.com (Anton Vorontsov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: cns3xxx: Add support for AHCI controllers
Date: Wed, 2 Jun 2010 16:29:44 +0400 [thread overview]
Message-ID: <20100602122944.GA11087@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <4C0623D8.6030701@ru.mvista.com>
On Wed, Jun 02, 2010 at 01:26:48PM +0400, Sergei Shtylyov wrote:
[...]
> >+ tmp = MISC_SATA_POWER_MODE;
> >+ tmp |= 0x1 << 16; /* Disable SATA PHY 0 from SLUMBER Mode */
> >+ tmp |= 0x1 << 17; /* Disable SATA PHY 1 from SLUMBER Mode */
> >+ MISC_SATA_POWER_MODE = tmp;
>
> Why aren't you using I/O accessors?
For CNS3xxx __raw_{read,write} are equivalent to direct accesses,
and originally Cavium used registers directly just because it was
easier (less keystrokes, quite understandable).
Ben Dooks also pointed out this concern, and I agree that using
IO accessors would be a good cleanup.
As I'm going to send other improvements, I think I'll fix this for
all CNS3xxx code base on top of this pull request, if nobody minds.
Thanks!
--
Anton Vorontsov
email: cbouatmailru at gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2010-06-02 12:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 16:54 [GIT PULL] Some Cavium CNS3xxx updates for 2.6.36 Anton Vorontsov
2010-06-01 16:55 ` [PATCH 1/4] ARM: cns3xxx: Add support for PCI Express ports Anton Vorontsov
2010-06-01 16:55 ` [PATCH 2/4] ARM: cns3xxx: Add support for SDHCI controllers Anton Vorontsov
2010-06-01 16:55 ` [PATCH 3/4] ARM: cns3xxx: Add support for AHCI controllers Anton Vorontsov
2010-06-02 9:26 ` Sergei Shtylyov
2010-06-02 12:29 ` Anton Vorontsov [this message]
2010-06-02 12:49 ` Sergei Shtylyov
2010-06-02 12:53 ` Anton Vorontsov
2010-06-02 12:54 ` Sergei Shtylyov
2010-06-02 13:07 ` Anton Vorontsov
2010-06-01 16:55 ` [PATCH 4/4] ARM: cns3xxx: Update defconfig to enable AHCI, PCIe and net devices Anton Vorontsov
2010-06-01 21:10 ` [GIT PULL] Some Cavium CNS3xxx updates for 2.6.36 Russell King - ARM Linux
2010-06-01 21:34 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602122944.GA11087@oksana.dev.rtsoft.ru \
--to=avorontsov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).