From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Augment __naked__ function attribute with __noinline__ and __noclone__
Date: Wed, 2 Jun 2010 16:59:47 +0100 [thread overview]
Message-ID: <20100602155947.GA872@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <19462.19024.560502.149871@pilspetsen.it.uu.se>
On Wed, Jun 02, 2010 at 02:10:56PM +0200, Mikael Pettersson wrote:
> Mikael Pettersson writes:
> > The asm() bodies of naked functions often depend on standard calling
> > conventions, therefore they must be noinline and noclone. GCC 4.[56]
> > currently fail to enforce this, see GCC PR44290. The effect is that
> > most arch/arm/mm/copypage-*.c modules get miscompiled, resulting in
> > kernel crashes during bootup.
> >
> > Part of the fix is to augment the __naked attribute to imply noinline
> > and noclone. This patch implements that, and has been verified to fix
> > the failure to boot a gcc-4.5 compiled 2.6.34 kernel on a Thecus n2100
> > (XScale-based mach-iop32x).
>
> Now also tested with a gcc-4.5 compiled 2.6.35-rc1 kernel on a ds101
> (XScale-based mach-ixp4xx).
I think this needs to go somewhere near linux-kernel.
prev parent reply other threads:[~2010-06-02 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 8:05 [PATCH] Augment __naked__ function attribute with __noinline__ and __noclone__ Mikael Pettersson
2010-06-02 12:10 ` Mikael Pettersson
2010-06-02 15:59 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602155947.GA872@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).