linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Add kto and kfrom to input operands list.
Date: Wed, 2 Jun 2010 17:00:11 +0100	[thread overview]
Message-ID: <20100602160010.GB872@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <19462.18892.533099.360440@pilspetsen.it.uu.se>

On Wed, Jun 02, 2010 at 02:08:44PM +0200, Mikael Pettersson wrote:
> Khem Raj writes:
>  > When functions incoming parameters are not in input operands list gcc 4.5 does not
>  > load the parameters into registers before calling this function but the
>  > inline assembly assumes valid addresses inside this function. This
>  > breaks the code because r0 and r1 are invalid when execution enters
>  > v4wb_copy_user_page ()
>  > 
>  > Also the constant needs to be used as third input operand so account for that
>  > as well.
>  > 
>  > Tested on qemu arm.
>  > 
>  > Signed-off-by: Khem Raj <raj.khem@gmail.com>
>  > ---
>  >  arch/arm/mm/copypage-feroceon.c |    4 ++--
> 
> I've tested and verified that this bit enables a gcc-4.5 compiled kernel
> to boot on TS-119 (Kirkwood) when combined with my fix for __naked.
> With neither or only one of the patches applied, the kernel oopses hard
> in copy_user_page() as it tries to start /sbin/init.
> 
> So for the copypage-feroceon.c change:
> Tested-by: Mikael Pettersson <mikpe@it.uu.se>

Ok.

      reply	other threads:[~2010-06-02 16:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-01  8:06 [PATCH] Add kto and kfrom to input operands list Khem Raj
2010-06-02 12:08 ` Mikael Pettersson
2010-06-02 16:00   ` Russell King - ARM Linux [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100602160010.GB872@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).