linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] i2c: Enable i2c-s3c2410 for S5P cpus
@ 2010-06-03  5:57 Joonyoung Shim
  2010-06-03  8:46 ` Ben Dooks
  0 siblings, 1 reply; 3+ messages in thread
From: Joonyoung Shim @ 2010-06-03  5:57 UTC (permalink / raw)
  To: linux-arm-kernel

This i2c controller driver can be used on the S5P series processors too,
so enable the driver in Konfig for those platforms.

Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/i2c/busses/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 87ab056..4765d62 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -503,7 +503,7 @@ config I2C_PXA_SLAVE
 
 config I2C_S3C2410
 	tristate "S3C2410 I2C Driver"
-	depends on ARCH_S3C2410 || ARCH_S3C64XX
+	depends on ARCH_S3C2410 || ARCH_S3C64XX || PLAT_S5P
 	help
 	  Say Y here to include support for I2C controller in the
 	  Samsung S3C2410 based System-on-Chip devices.
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] i2c: Enable i2c-s3c2410 for S5P cpus
  2010-06-03  5:57 [PATCH] i2c: Enable i2c-s3c2410 for S5P cpus Joonyoung Shim
@ 2010-06-03  8:46 ` Ben Dooks
  2010-06-03 10:27   ` Joonyoung Shim
  0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks @ 2010-06-03  8:46 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Jun 03, 2010 at 02:57:03PM +0900, Joonyoung Shim wrote:
> This i2c controller driver can be used on the S5P series processors too,
> so enable the driver in Konfig for those platforms.
> 
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  drivers/i2c/busses/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 87ab056..4765d62 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -503,7 +503,7 @@ config I2C_PXA_SLAVE
>  
>  config I2C_S3C2410
>  	tristate "S3C2410 I2C Driver"
> -	depends on ARCH_S3C2410 || ARCH_S3C64XX
> +	depends on ARCH_S3C2410 || ARCH_S3C64XX || PLAT_S5P

It may be worth changing this to PLAT_S3C24XX || ARCH_S3C64XX || PLAT_S5P
or maybe we should just enable it if PLAT_SAMSUNG

It would be good to get an policy sorted out on these core drivers which
exists across many parts of S3C/S5P supported systems.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] i2c: Enable i2c-s3c2410 for S5P cpus
  2010-06-03  8:46 ` Ben Dooks
@ 2010-06-03 10:27   ` Joonyoung Shim
  0 siblings, 0 replies; 3+ messages in thread
From: Joonyoung Shim @ 2010-06-03 10:27 UTC (permalink / raw)
  To: linux-arm-kernel

On 6/3/2010 5:46 PM, Ben Dooks wrote:
> On Thu, Jun 03, 2010 at 02:57:03PM +0900, Joonyoung Shim wrote:
>> This i2c controller driver can be used on the S5P series processors too,
>> so enable the driver in Konfig for those platforms.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>>  drivers/i2c/busses/Kconfig |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
>> index 87ab056..4765d62 100644
>> --- a/drivers/i2c/busses/Kconfig
>> +++ b/drivers/i2c/busses/Kconfig
>> @@ -503,7 +503,7 @@ config I2C_PXA_SLAVE
>>  
>>  config I2C_S3C2410
>>  	tristate "S3C2410 I2C Driver"
>> -	depends on ARCH_S3C2410 || ARCH_S3C64XX
>> +	depends on ARCH_S3C2410 || ARCH_S3C64XX || PLAT_S5P
> 
> It may be worth changing this to PLAT_S3C24XX || ARCH_S3C64XX || PLAT_S5P
> or maybe we should just enable it if PLAT_SAMSUNG
> 

I think PLAT_SAMSUNG is more appropriate thing if it is no problem.

> It would be good to get an policy sorted out on these core drivers which
> exists across many parts of S3C/S5P supported systems.
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-06-03 10:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-03  5:57 [PATCH] i2c: Enable i2c-s3c2410 for S5P cpus Joonyoung Shim
2010-06-03  8:46 ` Ben Dooks
2010-06-03 10:27   ` Joonyoung Shim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).