* [PATCH] S5PV210: Increase the VIC_NR as 4
@ 2010-06-03 10:09 Kyungmin Park
2010-06-03 10:31 ` Russell King - ARM Linux
0 siblings, 1 reply; 3+ messages in thread
From: Kyungmin Park @ 2010-06-03 10:09 UTC (permalink / raw)
To: linux-arm-kernel
The S5PV210 SoC have 4 VICs. It requires for suspend and resume.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/arch/arm/common/Kconfig b/arch/arm/common/Kconfig
index 0a34c81..0ac3d81 100644
--- a/arch/arm/common/Kconfig
+++ b/arch/arm/common/Kconfig
@@ -6,6 +6,7 @@ config ARM_VIC
config ARM_VIC_NR
int
+ default 4 if ARCH_S5PV210
default 2
depends on ARM_VIC
help
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] S5PV210: Increase the VIC_NR as 4
2010-06-03 10:09 [PATCH] S5PV210: Increase the VIC_NR as 4 Kyungmin Park
@ 2010-06-03 10:31 ` Russell King - ARM Linux
2010-06-03 13:36 ` Ben Dooks
0 siblings, 1 reply; 3+ messages in thread
From: Russell King - ARM Linux @ 2010-06-03 10:31 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 03, 2010 at 07:09:54PM +0900, Kyungmin Park wrote:
> The S5PV210 SoC have 4 VICs. It requires for suspend and resume.
Isn't this negated by Ben's "ARM: VIC: Allocate VIC PM device from slab"
patch?
Incidentally, shouldn't Ben's patch remove this configuration option too?
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>
> diff --git a/arch/arm/common/Kconfig b/arch/arm/common/Kconfig
> index 0a34c81..0ac3d81 100644
> --- a/arch/arm/common/Kconfig
> +++ b/arch/arm/common/Kconfig
> @@ -6,6 +6,7 @@ config ARM_VIC
>
> config ARM_VIC_NR
> int
> + default 4 if ARCH_S5PV210
> default 2
> depends on ARM_VIC
> help
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] S5PV210: Increase the VIC_NR as 4
2010-06-03 10:31 ` Russell King - ARM Linux
@ 2010-06-03 13:36 ` Ben Dooks
0 siblings, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2010-06-03 13:36 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 03, 2010 at 11:31:44AM +0100, Russell King - ARM Linux wrote:
> On Thu, Jun 03, 2010 at 07:09:54PM +0900, Kyungmin Park wrote:
> > The S5PV210 SoC have 4 VICs. It requires for suspend and resume.
>
> Isn't this negated by Ben's "ARM: VIC: Allocate VIC PM device from slab"
> patch?
I was awaiting the feedback from other archs which I don't have access
to...
> Incidentally, shouldn't Ben's patch remove this configuration option too?
Yes, you're right, should have removed these.
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> >
> > diff --git a/arch/arm/common/Kconfig b/arch/arm/common/Kconfig
> > index 0a34c81..0ac3d81 100644
> > --- a/arch/arm/common/Kconfig
> > +++ b/arch/arm/common/Kconfig
> > @@ -6,6 +6,7 @@ config ARM_VIC
> >
> > config ARM_VIC_NR
> > int
> > + default 4 if ARCH_S5PV210
> > default 2
> > depends on ARM_VIC
> > help
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-03 13:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-03 10:09 [PATCH] S5PV210: Increase the VIC_NR as 4 Kyungmin Park
2010-06-03 10:31 ` Russell King - ARM Linux
2010-06-03 13:36 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).