linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 00/14] omap: mailbox: bunch of cleanups
Date: Thu, 3 Jun 2010 19:15:53 +0300	[thread overview]
Message-ID: <20100603161553.GL30622@atomide.com> (raw)
In-Reply-To: <AANLkTinBMdcxzF_pZuiFHc1Eox_bYtD8PXG1OuKo0XWu@mail.gmail.com>

* Felipe Contreras <felipe.contreras@gmail.com> [100603 17:53]:
> On Thu, Jun 3, 2010 at 2:47 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Thu, Jun 03, 2010 at 09:40:22AM +0300, Hiroshi DOYU wrote:
> >> > Felipe Contreras (14):
> >> > ? omap: mailbox: trivial whitespace cleanups
> >> > ? omap: mailbox: trivial cleanups
> >
> > I think folk need to read this:
> >
> > ? ? ? ?http://lkml.org/lkml/2010/6/2/472
> >
> > and consider what it means for the future, and what can be done to reduce
> > the amount of "churn".
> 
> If I have to decipher that rant, my best guess is that he is
> complaining about the amount of code. If that's the case, this patch
> series is only doing good:
> 6 files changed, 168 insertions(+), 230 deletions(-)
> 
> Another part of the rant is the fact that Linus cannot follow the huge
> amount of changes. I think "trivial whitespace cleanups" pretty much
> says: don't look at me if you want to be productive, while "trivial
> cleanups" says, look at me if you feel like looking at easy changes.
> If I were to squash these two, I think the patch series would become
> harder to follow.
> 
> Something that helps in other projects, like git, is that merges are
> clearly identified.
> 
> Merge branch 'linux-arm'
>  Merge branch 'linux-omap'
>   Merge branch 'linux-omap-mbox'
>    Merge branch 'fc-cleanups'
>    Merge branch 'ob-kfifo'
> 
> Then it's a bit clearer what each patch series is doing in the mailbox
> tree without looking at individual patches.

Also we need to make sure all the code we merge is really tested
well before the merge window. Too much of the code needs to be
fixed after the merge window. For the upcoming merge window, we
will only merge things that have been sitting in the for-next
for days before the merge window opens.

Tony

      reply	other threads:[~2010-06-03 16:15 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-22 17:14 [PATCH v3 00/14] omap: mailbox: bunch of cleanups Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 01/14] omap: mailbox: trivial whitespace cleanups Felipe Contreras
2010-05-24 10:56   ` Hiroshi DOYU
2010-05-22 17:14 ` [PATCH v3 02/14] omap: mailbox: trivial cleanups Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 03/14] omap: mailbox: reorganize structures Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 04/14] omap: mailbox: 2420 should be detected at run-time Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 05/14] omap: mailbox: use correct config for omap1 Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 06/14] omap: mailbox: update omap1 probing Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 07/14] omap: mailbox: don't export unecessary symbols Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 08/14] omap: mailbox: remove unecessary fields Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 09/14] omap: mailbox: add IRQ names Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 10/14] omap: mailbox: reorganize registering Felipe Contreras
2010-05-24 15:24   ` Hiroshi DOYU
2010-05-24 18:32     ` Russell King - ARM Linux
2010-05-24 19:17       ` Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 11/14] omap: mailbox: only compile for configured archs Felipe Contreras
2010-05-24 14:42   ` Hiroshi DOYU
2010-05-24 19:29     ` Felipe Contreras
2010-05-24 21:00       ` Russell King - ARM Linux
2010-05-22 17:14 ` [PATCH v3 12/14] omap: mailbox: standarize on 'omap-mailbox' Felipe Contreras
2010-05-22 17:14 ` [PATCH v3 13/14] omap: mailbox: simplify omap_mbox_register() Felipe Contreras
2010-05-24 14:42   ` Hiroshi DOYU
2010-06-11 15:17     ` Felipe Contreras
2010-06-11 15:19       ` Felipe Contreras
2010-05-24 15:14   ` Hiroshi DOYU
2010-05-22 17:14 ` [PATCH v3 14/14] omap: mailbox: reorganize headers Felipe Contreras
2010-05-24 17:16   ` Felipe Balbi
2010-05-24 19:14     ` Felipe Contreras
2010-05-25  5:49       ` Felipe Balbi
2010-05-25 18:04         ` Felipe Contreras
2010-06-03  6:40 ` [PATCH v3 00/14] omap: mailbox: bunch of cleanups Hiroshi DOYU
2010-06-03 10:23   ` Felipe Contreras
2010-06-03 10:59     ` Hiroshi DOYU
2010-06-03 11:47   ` Russell King - ARM Linux
2010-06-03 11:56     ` Felipe Balbi
2010-06-03 12:05     ` Baruch Siach
2010-06-03 14:59     ` Felipe Contreras
2010-06-03 16:15       ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100603161553.GL30622@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).