linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: amit.kucheria@canonical.com (Amit Kucheria)
To: linux-arm-kernel@lists.infradead.org
Subject: [V2 1/3] mxc: Add support for the imx51 3-stack board
Date: Fri, 4 Jun 2010 13:53:47 +0300	[thread overview]
Message-ID: <20100604105347.GA2982@matterhorn.lan> (raw)
In-Reply-To: <20100604085320.GB25357@pengutronix.de>

On 10 Jun 04, Sascha Hauer wrote:
> On Thu, Jun 03, 2010 at 08:05:44PM +0800, Jason Wang wrote:
> >  
> > -#define MX51_PAD_GPIO_1_22__UART3_RXD	IOMUX_PAD(0x630, 0x240, 3, 0x0, 0, NO_PAD_CTRL)
> > -#define MX51_PAD_GPIO_1_23__UART3_TXD	IOMUX_PAD(0x634, 0x244, 3, 0x0, 0, NO_PAD_CTRL)
> > +#define MX51_PAD_GPIO_1_22__UART3_RXD	IOMUX_PAD(0x630, 0x240, IOMUX_CONFIG_ALT1, 0x9f4, 4, MX51_UART3_PAD_CTRL)
> > +#define MX51_PAD_GPIO_1_23__UART3_TXD	IOMUX_PAD(0x634, 0x244, IOMUX_CONFIG_ALT1, 0x0, 0, MX51_UART3_PAD_CTRL)
> 
> Urgs, there really is something wrong here.
> 
> First of all, this define should be named MX51_PAD_UART3_RXD__GPIO_1_22
> as it describes the pad UART3_RXD in GPIO_1_22 mode. This seems to be
> wrong with many (all?) defines in this file. Amit, you should have read
> the comment ontop of this file which you copied from the i.MX35 part:

I'll admit that I was not completely conversant with the naming scheme then.
All the GPIO-related names have been reversed. The others seem fine.

> /*
>  * The naming convention for the pad modes is MX51_PAD_<padname>__<padmode>
>  * If <padname> or <padmode> refers to a GPIO, it is named
>  * GPIO_<unit>_<num> see also iomux-v3.h
>  */

There was a comment below this:
/*
 * FIXME: This was converted using scripts from existing Freescale code to
 * this form used upstream. Need to verify the name format.
 */

I obviously reversed the naming for all the GPIO pads.

> This should be fixed before doing any other change to this file.

I'm preparing a patch now.

> Then Jason, what you are looking for is the following:
> 
> #define MX51_PAD_UART3_RXD__UART3_RXD
> 
> because you want the UART3_RXD pad in its native mode.

Cheers,
Amit

-- 
----------------------------------------------------------------------
Amit Kucheria, Kernel Engineer || amit.kucheria at canonical.com
----------------------------------------------------------------------

  parent reply	other threads:[~2010-06-04 10:53 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-03 12:05 [V2 0/3]Add i.MX51 3-stack board support Jason Wang
2010-06-03 12:05 ` [V2 1/3] mxc: Add support for the imx51 3-stack board Jason Wang
2010-06-03 12:05   ` [V2 2/3] mxc/iomux: add GPIO bank offset for iomux v3 platforms Jason Wang
2010-06-03 12:05     ` [V2 3/3] mx51/keypad: add keypad support for i.MX51 platforms Jason Wang
2010-06-05  9:35       ` Alberto Panizzo
2010-06-05 14:13         ` jason
2010-06-06 18:11           ` Alberto Panizzo
2010-06-07 23:22             ` jason
2010-06-03 12:39   ` [V2 1/3] mxc: Add support for the imx51 3-stack board Amit Kucheria
2010-06-03 13:57     ` Sascha Hauer
2010-06-03 14:35       ` Amit Kucheria
2010-06-03 14:36       ` jason
2010-06-03 14:39     ` jason
2010-06-04  8:53   ` Sascha Hauer
2010-06-04  9:48     ` Alberto Panizzo
2010-06-04 15:22       ` Sascha Hauer
2010-06-04 10:53     ` Amit Kucheria [this message]
2010-06-04 14:09       ` [PATCH] mxc: Fix pad names for imx51 Amit Kucheria
2010-06-07 20:41         ` Troy Kisky
2010-06-07 21:04           ` Amit Kucheria
2010-06-07 21:15             ` Troy Kisky
2010-06-08  6:30               ` Sascha Hauer
2010-06-09 13:09                 ` Amit Kucheria
2010-06-10 11:49                   ` Sascha Hauer
2010-06-10 13:04                     ` jason
2010-06-10 13:59                       ` Sascha Hauer
2010-06-10 19:24                     ` Amit Kucheria
2010-06-04 12:50     ` [V2 1/3] mxc: Add support for the imx51 3-stack board jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100604105347.GA2982@matterhorn.lan \
    --to=amit.kucheria@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).