From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] backlight: Fix blanking for L4F00242T03 LCD
Date: Sat, 5 Jun 2010 11:47:22 +0200 [thread overview]
Message-ID: <201006051147.22655.marek.vasut@gmail.com> (raw)
In-Reply-To: <1275729924.3446.13.camel@realization>
Dne So 5. ?ervna 2010 11:25:24 Alberto Panizzo napsal(a):
> On sab, 2010-06-05 at 03:25 +0200, Marek Vasut wrote:
> > The LCD was turned on if the variable power was > 0, but that was
> > incorrect. The LCD has to be turned on in every case but POWERDOWN.
>
> The patch is ok for me, but the comment could much more reflect what
> the patch does, no?
Thanks for validating my work, we'll have another round ;)
>
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > ---
> >
> > drivers/video/backlight/l4f00242t03.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/video/backlight/l4f00242t03.c
> > b/drivers/video/backlight/l4f00242t03.c index 9093ef0..c67801e 100644
> > --- a/drivers/video/backlight/l4f00242t03.c
> > +++ b/drivers/video/backlight/l4f00242t03.c
> > @@ -78,7 +78,7 @@ static int l4f00242t03_lcd_power_set(struct lcd_device
> > *ld, int power)
> >
> > const u16 slpin = 0x10;
> > const u16 disoff = 0x28;
> >
> > - if (power) {
> > + if (power <= FB_BLANK_NORMAL) {
> >
> > if (priv->lcd_on)
> >
> > return 0;
next prev parent reply other threads:[~2010-06-05 9:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 1:25 [PATCH 1/2] backlight: Fix blanking for LMS283GF05 LCD Marek Vasut
2010-06-05 1:25 ` [PATCH 2/2] backlight: Fix blanking for L4F00242T03 LCD Marek Vasut
2010-06-05 9:25 ` Alberto Panizzo
2010-06-05 9:47 ` Marek Vasut [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-06-05 9:50 [PATCH 1/2] backlight: Fix blanking for LMS283GF05 LCD Marek Vasut
2010-06-05 9:50 ` [PATCH 2/2] backlight: Fix blanking for L4F00242T03 LCD Marek Vasut
2010-11-05 10:48 ` Alberto Panizzo
2010-11-05 11:09 ` Richard Purdie
2010-11-05 11:20 ` Alberto Panizzo
2010-06-04 5:52 [PATCH 1/2] backlight: Fix blanking for LMS283GF05 LCD Marek Vasut
2010-06-04 5:52 ` [PATCH 2/2] backlight: Fix blanking for L4F00242T03 LCD Marek Vasut
2010-06-04 7:29 ` Alberto Panizzo
2010-06-05 1:25 ` Marek Vasut
2010-06-05 9:22 ` Alberto Panizzo
2010-06-05 9:46 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006051147.22655.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).