From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH]ARM/footbridge: fix wrong parenthesis
Date: Mon, 7 Jun 2010 15:01:31 +0100 [thread overview]
Message-ID: <20100607140131.GA7220@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4C08C749.3050700@gmail.com>
On Fri, Jun 04, 2010 at 05:28:41PM +0800, Wan ZongShun wrote:
> There is a wrong redundant right parenthesis in this code.
This patch is wrong.
> unsigned long __pfn_to_bus(unsigned long pfn)
> {
> - return __pfn_to_phys(pfn) + (fb_bus_sdram_offset() - PHYS_OFFSET));
> + return __pfn_to_phys(pfn + (fb_bus_sdram_offset() - PHYS_OFFSET));
It makes no sense to add byte address offsets to a PFN. The correct
solution is to delete the right paren at the end of the line instead.
next prev parent reply other threads:[~2010-06-07 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 9:28 [PATCH]ARM/footbridge: fix wrong parenthesis Wan ZongShun
2010-06-07 14:01 ` Russell King - ARM Linux [this message]
2010-06-07 14:12 ` Wan ZongShun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100607140131.GA7220@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).