* [PATCH] s5pc110: SDHCI-s3c can override host capabilities
@ 2010-06-05 2:40 Kyungmin Park
2010-06-10 20:43 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Kyungmin Park @ 2010-06-05 2:40 UTC (permalink / raw)
To: linux-arm-kernel
Each board can override the default sdhci host capabilities.
Some board has broken features by hardwares and support 8-bit bandwidth.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/arch/arm/plat-samsung/dev-hsmmc.c b/arch/arm/plat-samsung/dev-hsmmc.c
index 4c05b39..d0887da 100644
--- a/arch/arm/plat-samsung/dev-hsmmc.c
+++ b/arch/arm/plat-samsung/dev-hsmmc.c
@@ -65,4 +65,6 @@ void s3c_sdhci0_set_platdata(struct s3c_sdhci_platdata *pd)
set->cfg_gpio = pd->cfg_gpio;
if (pd->cfg_card)
set->cfg_card = pd->cfg_card;
+ if (pd->host_caps)
+ set->host_caps = pd->host_caps;
}
diff --git a/arch/arm/plat-samsung/dev-hsmmc1.c b/arch/arm/plat-samsung/dev-hsmmc1.c
index e49bc4c..e45a82e 100644
--- a/arch/arm/plat-samsung/dev-hsmmc1.c
+++ b/arch/arm/plat-samsung/dev-hsmmc1.c
@@ -65,4 +65,6 @@ void s3c_sdhci1_set_platdata(struct s3c_sdhci_platdata *pd)
set->cfg_gpio = pd->cfg_gpio;
if (pd->cfg_card)
set->cfg_card = pd->cfg_card;
+ if (pd->host_caps)
+ set->host_caps = pd->host_caps;
}
diff --git a/arch/arm/plat-samsung/dev-hsmmc2.c b/arch/arm/plat-samsung/dev-hsmmc2.c
index 824580b..5ee3b89 100644
--- a/arch/arm/plat-samsung/dev-hsmmc2.c
+++ b/arch/arm/plat-samsung/dev-hsmmc2.c
@@ -66,4 +66,6 @@ void s3c_sdhci2_set_platdata(struct s3c_sdhci_platdata *pd)
set->cfg_gpio = pd->cfg_gpio;
if (pd->cfg_card)
set->cfg_card = pd->cfg_card;
+ if (pd->host_caps)
+ set->host_caps = pd->host_caps;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] s5pc110: SDHCI-s3c can override host capabilities
2010-06-05 2:40 [PATCH] s5pc110: SDHCI-s3c can override host capabilities Kyungmin Park
@ 2010-06-10 20:43 ` Andrew Morton
2010-06-10 23:06 ` Kyungmin Park
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2010-06-10 20:43 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, 05 Jun 2010 11:40:53 +0900
Kyungmin Park <kmpark@infradead.org> wrote:
> From: Kyungmin Park <kmpark@infradead.org>
> To: linux-arm-kernel at lists.infradead.org, linux-mmc at vger.kernel.org, akpm at linux-foundation.org, ben-linux at fluff.org
> Subject: [PATCH] s5pc110: SDHCI-s3c can override host capabilities
> Date: Sat, 05 Jun 2010 11:40:53 +0900
> User-Agent: Mutt/1.5.14 (2007-02-12)
>
> Each board can override the default sdhci host capabilities.
> Some board has broken features by hardwares and support 8-bit bandwidth.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
The way this patch was presented, it will go into git with an Author:
address of "kmpark at infradead.org", but a Signed-off-by: address of
"kyungmin.park at samsung.com". Which is a little odd.
The way to prevent that is to put an explicit "From:" line at the top
of the changelog. If that line is absent, people's tools will fall
back to the From: line in the mail headers, which is what happened
here.
Please let me know if you want me to make any changes to these three
patches.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] s5pc110: SDHCI-s3c can override host capabilities
2010-06-10 20:43 ` Andrew Morton
@ 2010-06-10 23:06 ` Kyungmin Park
0 siblings, 0 replies; 3+ messages in thread
From: Kyungmin Park @ 2010-06-10 23:06 UTC (permalink / raw)
To: linux-arm-kernel
hi,
On Fri, Jun 11, 2010 at 5:43 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Sat, 05 Jun 2010 11:40:53 +0900
> Kyungmin Park <kmpark@infradead.org> wrote:
>
>> From: Kyungmin Park <kmpark@infradead.org>
>> To: linux-arm-kernel at lists.infradead.org, linux-mmc at vger.kernel.org, akpm at linux-foundation.org, ben-linux at fluff.org
>> Subject: [PATCH] s5pc110: SDHCI-s3c can override host capabilities
>> Date: Sat, 05 Jun 2010 11:40:53 +0900
>> User-Agent: Mutt/1.5.14 (2007-02-12)
>>
>> Each board can override the default sdhci host capabilities.
>> Some board has broken features by hardwares and support 8-bit bandwidth.
>>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> The way this patch was presented, it will go into git with an Author:
> address of "kmpark at infradead.org", but a Signed-off-by: address of
> "kyungmin.park at samsung.com". ?Which is a little odd.
>
> The way to prevent that is to put an explicit "From:" line at the top
> of the changelog. ?If that line is absent, people's tools will fall
> back to the From: line in the mail headers, which is what happened
> here.
>
> Please let me know if you want me to make any changes to these three
> patches.
>
No problem, please fix it freely.
Next time, I'll add the From line.
One more, mails from Marek has duplicated patches, so please ignore it.
Thank you,
Kyungmin Park
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-10 23:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-05 2:40 [PATCH] s5pc110: SDHCI-s3c can override host capabilities Kyungmin Park
2010-06-10 20:43 ` Andrew Morton
2010-06-10 23:06 ` Kyungmin Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).