linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] NUC900:  Add i2c0 driver support for NUC900
Date: Wed, 16 Jun 2010 02:05:03 +0200	[thread overview]
Message-ID: <201006160205.04009.marek.vasut@gmail.com> (raw)
In-Reply-To: <20100615051905.GD3233@jasper.tkos.co.il>

Dne ?t 15. ?ervna 2010 07:19:05 Baruch Siach napsal(a):
> Hi Wan,
> 
> On Mon, Jun 14, 2010 at 01:24:12AM +0800, Wan ZongShun wrote:
> > This patch is to add i2c0 driver support for NUC900.
> > 
> > Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
> > 
> > ---
> 
> [snip]
> 
> > +	pdata->get_clock(NULL, NULL, &apbclk_khz);
> 
> Why not use clk_get_rate() for this?
> 
> baruch

Other but what you already pointed out I can't find.

Reviewed-by: Marek Vasut <marek.vasut@gmail.com>

  reply	other threads:[~2010-06-16  0:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-13 17:24 [PATCH 1/2] NUC900: Add i2c0 driver support for NUC900 Wan ZongShun
2010-06-15  5:19 ` Baruch Siach
2010-06-16  0:05   ` Marek Vasut [this message]
2010-06-20 22:38 ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006160205.04009.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).