linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] GPIO PL061: Adding Clk framework support
Date: Mon, 21 Jun 2010 21:11:21 +0530	[thread overview]
Message-ID: <20100621154121.GA4290@debian> (raw)
In-Reply-To: <1277103463-7311-1-git-send-email-viresh.kumar@st.com>

On Mon, Jun 21, 2010 at 12:27:43PM +0530, Viresh KUMAR wrote:
> GPIO Clk is never enabled on Platforms, like: SPEAr, which are based upon clock
> framework and use PL061 driver. This patch adds support for Clk enabling and
> disabling as and when gpios are requested and freed.
[...]
> +	chip->clk = clk_get(&dev->dev, NULL);
> +	if (IS_ERR(chip->clk)) {
> +		ret = PTR_ERR(chip->clk);
> +		goto iounmap;
> +	}

Have you verified that all platforms using this driver already have
clocks with the appropriate names?   Otherwise this patch will break
those platforms.

Rabin

  reply	other threads:[~2010-06-21 15:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-21  6:57 [PATCH V2] GPIO PL061: Adding Clk framework support Viresh KUMAR
2010-06-21 15:41 ` Rabin Vincent [this message]
2010-06-21 17:34   ` Linus Walleij
2010-06-22  4:00     ` Viresh KUMAR
2010-06-21 17:41 ` Baruch Siach
2010-06-22  4:07   ` Viresh KUMAR
  -- strict thread matches above, loose matches on Subject: below --
2010-06-22  4:07 [PATCH v2] " Viresh KUMAR
2010-06-22  4:21 ` Rabin Vincent
2010-06-22  4:42   ` Viresh KUMAR

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100621154121.GA4290@debian \
    --to=rabin@rab.in \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).