From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm: Make VFPv3 usable on ARMv6
Date: Tue, 22 Jun 2010 16:20:38 +0300 [thread overview]
Message-ID: <20100622132037.GV12255@atomide.com> (raw)
In-Reply-To: <1277211592.29532.20.camel@e102109-lin.cambridge.arm.com>
* Catalin Marinas <catalin.marinas@arm.com> [100622 15:53]:
> On Mon, 2010-06-21 at 14:51 +0100, Tony Lindgren wrote:
> > diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c
> > index 315a540..19ba626 100644
> > --- a/arch/arm/vfp/vfpmodule.c
> > +++ b/arch/arm/vfp/vfpmodule.c
> > @@ -549,10 +549,14 @@ static int __init vfp_init(void)
> > /*
> > * Check for the presence of the Advanced SIMD
> > * load/store instructions, integer and single
> > - * precision floating point operations.
> > + * precision floating point operations. Only check
> > + * for NEON if the hardware has TLS register as the
> > + * MVFR registers got added in ARM1136 r1p0 with TLS.
> > */
> > - if ((fmrx(MVFR1) & 0x000fff00) == 0x00011100)
> > - elf_hwcap |= HWCAP_NEON;
> > + if (elf_hwcap & HWCAP_TLS) {
> > + if ((fmrx(MVFR1) & 0x000fff00) == 0x00011100)
> > + elf_hwcap |= HWCAP_NEON;
> > + }
>
> MVFR should be available with the new CPU id format:
>
> ((read_cpuid_id() & 0x000f0000) == 0x000f0000)
>
> I think that would be a cleaner test than relying on the TLS presence.
OK, thanks that's better. Will update accordingly and repost.
Tony
next prev parent reply other threads:[~2010-06-22 13:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 13:51 [PATCH 0/2] Make ARMv6 behave with TLS, VFPv3, and NEON Tony Lindgren
2010-06-21 13:51 ` [PATCH 1/2] arm: Replace CONFIG_HAS_TLS_REG with HWCAP_TLS and check for it on V6 Tony Lindgren
2010-06-22 9:28 ` Tony Lindgren
2010-06-22 17:00 ` Jamie Lokier
2010-06-23 7:39 ` Tony Lindgren
2010-06-23 8:12 ` Russell King - ARM Linux
2010-06-23 9:28 ` Tony Lindgren
2010-06-23 9:32 ` Russell King - ARM Linux
2010-06-23 13:28 ` Jamie Lokier
2010-06-23 13:36 ` Jamie Lokier
2010-06-23 14:19 ` Nicolas Pitre
2010-06-24 0:28 ` Jamie Lokier
2010-06-29 14:18 ` Tony Lindgren
2010-06-29 19:20 ` Nicolas Pitre
2010-06-30 11:08 ` Tony Lindgren
2010-06-30 13:17 ` Tony Lindgren
2010-06-30 14:42 ` Nicolas Pitre
2010-07-01 9:25 ` Tony Lindgren
2010-07-01 17:40 ` Jamie Lokier
2010-07-02 2:37 ` Nicolas Pitre
2010-07-02 10:37 ` Tony Lindgren
2010-07-05 13:55 ` Tony Lindgren
2011-04-08 3:39 ` Li Li
2011-04-08 13:19 ` Nicolas Pitre
2011-04-08 13:35 ` Li Li
2011-04-08 14:35 ` Jamie Lokier
2011-04-08 14:40 ` Li Li
2010-06-21 13:51 ` [PATCH 2/2] arm: Make VFPv3 usable on ARMv6 Tony Lindgren
2010-06-22 12:59 ` Catalin Marinas
2010-06-22 13:20 ` Tony Lindgren [this message]
2010-06-23 7:57 ` Tony Lindgren
2010-06-25 13:50 ` Catalin Marinas
2010-07-01 12:42 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100622132037.GV12255@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).