From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MMC: remove regulator refcount fiddling in mmc core
Date: Fri, 25 Jun 2010 12:22:32 +0100 [thread overview]
Message-ID: <20100625112232.GA21217@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1277392337-27627-1-git-send-email-linus.walleij@stericsson.com>
On Thu, Jun 24, 2010 at 05:12:17PM +0200, Linus Walleij wrote:
> Currently the mmc_regulator_set_ocr() fiddles with the regulator
> refcount by selectively calling regulator_[enable|disable]
> depending on the state of the regulator. This will confuse the
> reference count if case the regulator is for example shared with
> other MMC slots or user for other stuff than the MMC card.
> Push regulator_[enable|disable] out into the MMC host drivers
> and remove this from the MMC core so the reference count can be
> trusted.
So, the feedback from folks at the time this was originally written was
that the MMC code was unable to cope with sharing regulators since it
really needs to be able to set specific voltages. This needn't be a
showstopper since people can force a single voltage in the constraints
but it does need to be considered here.
next prev parent reply other threads:[~2010-06-25 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 15:12 [PATCH] MMC: remove regulator refcount fiddling in mmc core Linus Walleij
2010-06-25 11:22 ` Mark Brown [this message]
2010-06-26 17:37 ` Linus Walleij
2010-06-26 20:37 ` Mark Brown
2010-06-28 7:25 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100625112232.GA21217@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).