From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/8] ARM: S5PV310: Add IRQ support
Date: Mon, 28 Jun 2010 20:17:43 +0530 [thread overview]
Message-ID: <20100628144743.GB3287@debian> (raw)
In-Reply-To: <1277476037-8806-5-git-send-email-kgene.kim@samsung.com>
On Fri, Jun 25, 2010 at 11:27:13PM +0900, Kukjin Kim wrote:
> +static DEFINE_SPINLOCK(irq_controller_lock);
Hmm, why is this lock needed? The uses below don't seem like they need
locking:
> +static void combiner_mask_irq(unsigned int irq)
> +{
> + u32 mask = 1 << (irq % 32);
> +
> + spin_lock(&irq_controller_lock);
> + __raw_writel(mask, combiner_base(irq) + COMBINER_ENABLE_CLEAR);
> + spin_unlock(&irq_controller_lock);
> +}
> +
> +static void combiner_unmask_irq(unsigned int irq)
> +{
> + u32 mask = 1 << (irq % 32);
> +
> + spin_lock(&irq_controller_lock);
> + __raw_writel(mask, combiner_base(irq) + COMBINER_ENABLE_SET);
> + spin_unlock(&irq_controller_lock);
> +}
> +
> +static void combiner_handle_cascade_irq(unsigned int irq, struct irq_desc *desc)
> +{
...
> + spin_lock(&irq_controller_lock);
> + status = __raw_readl(chip_data->base + COMBINER_INT_STATUS);
> + spin_unlock(&irq_controller_lock);
next prev parent reply other threads:[~2010-06-28 14:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 14:27 [PATCH 0/8] ARM: S5PV310: Add support for Samsung S5PV310 SoC Kukjin Kim
2010-06-25 14:27 ` [PATCH 1/8] ARM: S5P: Remove fixed uart offset dependent code Kukjin Kim
2010-06-25 14:27 ` [PATCH 2/8] ARM: S5PV310: Add new CPU initialization support Kukjin Kim
2010-06-25 14:27 ` [PATCH 3/8] ARM: S5PV310: Add Clock and PLL support Kukjin Kim
2010-06-25 14:27 ` [PATCH 4/8] ARM: S5PV310: Add IRQ support Kukjin Kim
2010-06-28 14:47 ` Rabin Vincent [this message]
2010-06-25 14:27 ` [PATCH 5/8] ARM: S5PV310: Add Timer support Kukjin Kim
2010-06-28 15:19 ` Rabin Vincent
2010-06-29 11:23 ` Kukjin Kim
2010-06-25 14:27 ` [PATCH 6/8] ARM: S5PV310: Add new Kconfig and Makefiles Kukjin Kim
2010-06-25 14:27 ` [PATCH 7/8] ARM: S5PV310: Add Board support file Kukjin Kim
2010-06-25 14:27 ` [PATCH 8/8] ARM: S5PV310: Add serial port support Kukjin Kim
2010-07-01 9:52 ` Kyungmin Park
2010-07-01 9:49 ` [PATCH 0/8] ARM: S5PV310: Add support for Samsung S5PV310 SoC Kyungmin Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628144743.GB3287@debian \
--to=rabin@rab.in \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox