linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm: Replace CONFIG_HAS_TLS_REG with HWCAP_TLS and check for it on V6
Date: Thu, 1 Jul 2010 12:25:10 +0300	[thread overview]
Message-ID: <20100701092510.GH2822@atomide.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1006301011520.24097@xanadu.home>

* Nicolas Pitre <nico@fluxnic.net> [100630 17:36]:
> On Wed, 30 Jun 2010, Tony Lindgren wrote:
> 
> > * Tony Lindgren <tony@atomide.com> [100630 14:02]:
> > > * Nicolas Pitre <nico@fluxnic.net> [100629 22:14]:
> > > 
> > > Updated patch below.
> > 
> > And a bug crept in..
> > 
> > > +	.macro set_tls_v6, tp, tmp1, tmp2
> > > +	ldr	\tmp1, =elf_hwcap
> > > +	ldr	\tmp1, [\tmp1, #0]
> > > +	mov	\tmp2, #0xffff0fff
> > > +	tst	\tmp2, #HWCAP_TLS		@ hardware TLS available?
> > > +	mcrne	p15, 0, \tp, c13, c0, 3		@ yes, set TLS register
> > > +	streq	\tp, [\tmp2, #-15]		@ set TLS value at 0xffff0ff0
> > > +	.endm
> > 
> > The tst	\tmp2, #HWCAP_TLS should of course use \tmp1.
> > 
> > Also fixed a warning about adding parentheses around comparison
> > if (id & 0x410f0000) != 0x41070000).
> 
> Here you probably want (id & 0xff0f0000) and not (id & 0x410f0000).

Thanks, fixed.
 
> > Again, updated patch below.
> 
> I like it.  However, in proc-v6.S, you don't need to add a reference to 
> feat_v6_fixup() to the __pj4_v6_proc_info block.  Simply adding 
> HWCAP_TLS in that case should be fine as PJ4 always has the TLS reg.

Fixed that too.
 
> With the above fixes, you can add
> 
> Reviewed-by: Nicolas Pitre <nicolas.pitre@linaro.org>

Thanks, updated patch below.

Tony
-------------- next part --------------
A non-text attachment was scrubbed...
Name: arm-tls-v6.patch
Type: text/x-diff
Size: 8726 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100701/fa791efd/attachment-0001.bin>

  reply	other threads:[~2010-07-01  9:25 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-21 13:51 [PATCH 0/2] Make ARMv6 behave with TLS, VFPv3, and NEON Tony Lindgren
2010-06-21 13:51 ` [PATCH 1/2] arm: Replace CONFIG_HAS_TLS_REG with HWCAP_TLS and check for it on V6 Tony Lindgren
2010-06-22  9:28   ` Tony Lindgren
2010-06-22 17:00   ` Jamie Lokier
2010-06-23  7:39     ` Tony Lindgren
2010-06-23  8:12       ` Russell King - ARM Linux
2010-06-23  9:28         ` Tony Lindgren
2010-06-23  9:32           ` Russell King - ARM Linux
2010-06-23 13:28           ` Jamie Lokier
2010-06-23 13:36       ` Jamie Lokier
2010-06-23 14:19         ` Nicolas Pitre
2010-06-24  0:28           ` Jamie Lokier
2010-06-29 14:18         ` Tony Lindgren
2010-06-29 19:20           ` Nicolas Pitre
2010-06-30 11:08             ` Tony Lindgren
2010-06-30 13:17               ` Tony Lindgren
2010-06-30 14:42                 ` Nicolas Pitre
2010-07-01  9:25                   ` Tony Lindgren [this message]
2010-07-01 17:40                     ` Jamie Lokier
2010-07-02  2:37                       ` Nicolas Pitre
2010-07-02 10:37                         ` Tony Lindgren
2010-07-05 13:55                           ` Tony Lindgren
2011-04-08  3:39                             ` Li Li
2011-04-08 13:19                               ` Nicolas Pitre
2011-04-08 13:35                                 ` Li Li
2011-04-08 14:35                                   ` Jamie Lokier
2011-04-08 14:40                                     ` Li Li
2010-06-21 13:51 ` [PATCH 2/2] arm: Make VFPv3 usable on ARMv6 Tony Lindgren
2010-06-22 12:59   ` Catalin Marinas
2010-06-22 13:20     ` Tony Lindgren
2010-06-23  7:57       ` Tony Lindgren
2010-06-25 13:50         ` Catalin Marinas
2010-07-01 12:42           ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100701092510.GH2822@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).