From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Stop secondary cpus in machine_halt()
Date: Thu, 1 Jul 2010 19:10:47 -0500 [thread overview]
Message-ID: <20100702001047.GA26647@lixom.net> (raw)
In-Reply-To: <20100701231128.GA19906@n2100.arm.linux.org.uk>
On Fri, Jul 02, 2010 at 12:11:28AM +0100, Russell King - ARM Linux wrote:
> On Thu, Jul 01, 2010 at 05:47:06PM -0500, Olof Johansson wrote:
> > ARM doesn't spin down secondary cpus on halt, which results in interrupts
> > being delivered even after the "System halted" message, etc.
> >
> > Change that to use smp_send_stop() to halt them. Also, change the
> > smp_send_stop() on ARM to not do a stack dump when stopping.
>
> Actually, we want stack dumps - sometimes. For instance, when we
> panic() or similar.
Do we really want the stack dumps of all cpus at panic time? They won't be
printed precisely since the IPI takes a while to make it over.
As the size of SMP systems grow, it'll also become too spammy.
Anyway, the patch only changes behaviour when the system_state is
SYSTEM_HALT, i.e. during shutdown so all other panics will still
dump stacks from all cpus.
-Olof
next prev parent reply other threads:[~2010-07-02 0:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 22:47 [PATCH] ARM: Stop secondary cpus in machine_halt() Olof Johansson
2010-07-01 23:11 ` Russell King - ARM Linux
2010-07-02 0:10 ` Olof Johansson [this message]
2010-07-03 18:46 ` [PATCH v2] " Olof Johansson
2010-07-12 16:48 ` Russell King - ARM Linux
2010-07-26 12:31 ` Russell King - ARM Linux
2010-07-26 15:26 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100702001047.GA26647@lixom.net \
--to=olof@lixom.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).