* [PATCH] s5pc110: Reduce the iodesc length of systimer @ 2010-07-08 2:36 Kyungmin Park 2010-07-08 11:05 ` Kukjin Kim 2010-07-08 11:17 ` Kukjin Kim 0 siblings, 2 replies; 6+ messages in thread From: Kyungmin Park @ 2010-07-08 2:36 UTC (permalink / raw) To: linux-arm-kernel From: Kyungmin Park <kyungmin.park@samsung.com> It's enough to use 4KiB. Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm/mach-s5pv210/cpu.c index 411a4a9..07b86d2 100644 --- a/arch/arm/mach-s5pv210/cpu.c +++ b/arch/arm/mach-s5pv210/cpu.c @@ -41,7 +41,7 @@ static struct map_desc s5pv210_iodesc[] __initdata = { { .virtual = (unsigned long)S5P_VA_SYSTIMER, .pfn = __phys_to_pfn(S5PV210_PA_SYSTIMER), - .length = SZ_1M, + .length = SZ_4K, .type = MT_DEVICE, }, { .virtual = (unsigned long)VA_VIC2, ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] s5pc110: Reduce the iodesc length of systimer 2010-07-08 2:36 [PATCH] s5pc110: Reduce the iodesc length of systimer Kyungmin Park @ 2010-07-08 11:05 ` Kukjin Kim 2010-07-08 11:40 ` Kyungmin Park 2010-07-08 11:17 ` Kukjin Kim 1 sibling, 1 reply; 6+ messages in thread From: Kukjin Kim @ 2010-07-08 11:05 UTC (permalink / raw) To: linux-arm-kernel Kyungmin Park wrote: > > From: Kyungmin Park <kyungmin.park@samsung.com> > > It's enough to use 4KiB. > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> Where is submitter(kmpark at infradead.org)'s Signed-off-by? I know submitter and author in here are same...but e-mail. So added 'From' in your patch. It would be helpful to me if you use same e-mail in a patch. Also, the commit message needs to be more descriptive. > --- > diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm/mach-s5pv210/cpu.c > index 411a4a9..07b86d2 100644 > --- a/arch/arm/mach-s5pv210/cpu.c > +++ b/arch/arm/mach-s5pv210/cpu.c > @@ -41,7 +41,7 @@ static struct map_desc s5pv210_iodesc[] __initdata = { > { > .virtual = (unsigned long)S5P_VA_SYSTIMER, > .pfn = __phys_to_pfn(S5PV210_PA_SYSTIMER), > - .length = SZ_1M, > + .length = SZ_4K, > .type = MT_DEVICE, > }, { > .virtual = (unsigned long)VA_VIC2, > Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] s5pc110: Reduce the iodesc length of systimer 2010-07-08 11:05 ` Kukjin Kim @ 2010-07-08 11:40 ` Kyungmin Park 2010-07-08 12:34 ` Kukjin Kim 2010-07-08 17:31 ` Andrew Morton 0 siblings, 2 replies; 6+ messages in thread From: Kyungmin Park @ 2010-07-08 11:40 UTC (permalink / raw) To: linux-arm-kernel Hi Andrew, Can you explain Mr. Kim request? As your suggestion, If the sender and signed-off are different, add the From filed at body. I think no need to add duplicated signed-off since it's same person. Thank you, Kyungmin Park On Thu, Jul 8, 2010 at 8:05 PM, Kukjin Kim <kgene.kim@samsung.com> wrote: > Kyungmin Park wrote: >> >> From: Kyungmin Park <kyungmin.park@samsung.com> >> >> It's enough to use 4KiB. >> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > Where is submitter(kmpark at infradead.org)'s Signed-off-by? > I know submitter and author in here are same...but e-mail. > So added 'From' in your patch. > > It would be helpful to me if you use same e-mail in a patch. > > Also, the commit message needs to be more descriptive. > >> --- >> diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm/mach-s5pv210/cpu.c >> index 411a4a9..07b86d2 100644 >> --- a/arch/arm/mach-s5pv210/cpu.c >> +++ b/arch/arm/mach-s5pv210/cpu.c >> @@ -41,7 +41,7 @@ static struct map_desc s5pv210_iodesc[] __initdata = { >> ? ? ? { >> ? ? ? ? ? ? ? .virtual ? ? ? ?= (unsigned long)S5P_VA_SYSTIMER, >> ? ? ? ? ? ? ? .pfn ? ? ? ? ? ?= __phys_to_pfn(S5PV210_PA_SYSTIMER), >> - ? ? ? ? ? ? .length ? ? ? ? = SZ_1M, >> + ? ? ? ? ? ? .length ? ? ? ? = SZ_4K, >> ? ? ? ? ? ? ? .type ? ? ? ? ? = MT_DEVICE, >> ? ? ? }, { >> ? ? ? ? ? ? ? .virtual ? ? ? ?= (unsigned long)VA_VIC2, >> > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] s5pc110: Reduce the iodesc length of systimer 2010-07-08 11:40 ` Kyungmin Park @ 2010-07-08 12:34 ` Kukjin Kim 2010-07-08 17:31 ` Andrew Morton 1 sibling, 0 replies; 6+ messages in thread From: Kukjin Kim @ 2010-07-08 12:34 UTC (permalink / raw) To: linux-arm-kernel Kyungmin Park wrote: > > Hi Andrew, > > Can you explain Mr. Kim request? > As your suggestion, If the sender and signed-off are different, add > the From filed at body. > Yes I know, didn't see my posing? In this case, my suggestion is just use same e-mail in a patch. > I think no need to add duplicated signed-off since it's same person. > Maybe you misunderstood my comments. > Thank you, > Kyungmin Park > > > On Thu, Jul 8, 2010 at 8:05 PM, Kukjin Kim <kgene.kim@samsung.com> wrote: > > Kyungmin Park wrote: > >> > >> From: Kyungmin Park <kyungmin.park@samsung.com> > >> > >> It's enough to use 4KiB. > >> > >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > > > Where is submitter(kmpark at infradead.org)'s Signed-off-by? > > I know submitter and author in here are same...but e-mail. > > So added 'From' in your patch. > > > > It would be helpful to me if you use same e-mail in a patch. > > > > Also, the commit message needs to be more descriptive. > > > >> --- > >> diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm/mach-s5pv210/cpu.c > >> index 411a4a9..07b86d2 100644 > >> --- a/arch/arm/mach-s5pv210/cpu.c > >> +++ b/arch/arm/mach-s5pv210/cpu.c > >> @@ -41,7 +41,7 @@ static struct map_desc s5pv210_iodesc[] __initdata = { > >> ? ? ? { > >> ? ? ? ? ? ? ? .virtual ? ? ? ?= (unsigned long)S5P_VA_SYSTIMER, > >> ? ? ? ? ? ? ? .pfn ? ? ? ? ? ?= __phys_to_pfn(S5PV210_PA_SYSTIMER), > >> - ? ? ? ? ? ? .length ? ? ? ? = SZ_1M, > >> + ? ? ? ? ? ? .length ? ? ? ? = SZ_4K, > >> ? ? ? ? ? ? ? .type ? ? ? ? ? = MT_DEVICE, > >> ? ? ? }, { > >> ? ? ? ? ? ? ? .virtual ? ? ? ?= (unsigned long)VA_VIC2, > >> > > Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] s5pc110: Reduce the iodesc length of systimer 2010-07-08 11:40 ` Kyungmin Park 2010-07-08 12:34 ` Kukjin Kim @ 2010-07-08 17:31 ` Andrew Morton 1 sibling, 0 replies; 6+ messages in thread From: Andrew Morton @ 2010-07-08 17:31 UTC (permalink / raw) To: linux-arm-kernel On Thu, 8 Jul 2010 20:40:39 +0900 Kyungmin Park <kmpark@infradead.org> wrote: > Can you explain Mr. Kim request? > As your suggestion, If the sender and signed-off are different, add > the From filed at body. > > I think no need to add duplicated signed-off since it's same person. If you're sending a patch which someone else wrote then at a minimum it should have that person's From: at the top of the changelog and it should have your Signed-off-by:. However it is not required that the patch have the author's Signed-off-by:. See Documentation/SubmittingPatches, section 12. If you sent the patch and signed it then _you_ assert that it's OK to include the patch in Linux. That being said, we do prefer that both the author and the sender include their signoffs. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] s5pc110: Reduce the iodesc length of systimer 2010-07-08 2:36 [PATCH] s5pc110: Reduce the iodesc length of systimer Kyungmin Park 2010-07-08 11:05 ` Kukjin Kim @ 2010-07-08 11:17 ` Kukjin Kim 1 sibling, 0 replies; 6+ messages in thread From: Kukjin Kim @ 2010-07-08 11:17 UTC (permalink / raw) To: linux-arm-kernel Kukjin Kim wrote: > > Kyungmin Park wrote: > > > > From: Kyungmin Park <kyungmin.park@samsung.com> > > > > It's enough to use 4KiB. > > > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > Where is submitter(kmpark at infradead.org)'s Signed-off-by? > I know submitter and author in here are same...but e-mail. > So added 'From' in your patch. > > It would be helpful to me if you use same e-mail in a patch. > > Also, the commit message needs to be more descriptive. > I mean following is better. 'This patch reduces the iodesc length of System Timer from 1M to 4K.' May I apply this patch with above modified message? > > --- > > diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm/mach-s5pv210/cpu.c > > index 411a4a9..07b86d2 100644 > > --- a/arch/arm/mach-s5pv210/cpu.c > > +++ b/arch/arm/mach-s5pv210/cpu.c > > @@ -41,7 +41,7 @@ static struct map_desc s5pv210_iodesc[] __initdata = { > > { > > .virtual = (unsigned long)S5P_VA_SYSTIMER, > > .pfn = __phys_to_pfn(S5PV210_PA_SYSTIMER), > > - .length = SZ_1M, > > + .length = SZ_4K, > > .type = MT_DEVICE, > > }, { > > .virtual = (unsigned long)VA_VIC2, > > > Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-07-08 17:31 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-07-08 2:36 [PATCH] s5pc110: Reduce the iodesc length of systimer Kyungmin Park 2010-07-08 11:05 ` Kukjin Kim 2010-07-08 11:40 ` Kyungmin Park 2010-07-08 12:34 ` Kukjin Kim 2010-07-08 17:31 ` Andrew Morton 2010-07-08 11:17 ` Kukjin Kim
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).