From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] sdhci-s3c: add support for the non standard minimal clock value
Date: Fri, 9 Jul 2010 14:19:03 -0700 [thread overview]
Message-ID: <20100709141903.d883ad05.akpm@linux-foundation.org> (raw)
In-Reply-To: <1276670996-17729-3-git-send-email-m.szyprowski@samsung.com>
On Wed, 16 Jun 2010 08:49:55 +0200
Marek Szyprowski <m.szyprowski@samsung.com> wrote:
> S3C SDHCI host controller can change the source for generating mmc clock.
> By default host bus clock is used, what causes some problems on machines
> with 133MHz bus, because the SDHCI divider cannot be as high get proper
> clock value for identification mode. This is not a problem for the
> controller, because it can generate lower frequencies from other clock
> sources. This patch adds a new quirk to SDHCI driver to calculate the
> minimal supported clock frequency.
>
> This fixes the flood of the following warnings on Samsung S5PV210 SoCs:
> mmc0: Minimum clock frequency too high for identification mode
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/mmc/host/sdhci-of-esdhc.c | 1 +
> drivers/mmc/host/sdhci-s3c.c | 29 +++++++++++++++++++++++++++++
> drivers/mmc/host/sdhci.c | 2 +-
> drivers/mmc/host/sdhci.h | 2 ++
> 4 files changed, 33 insertions(+), 1 deletions(-)
This patch doesn't know about Anton's
sdhci-pltfm-add-support-for-cns3xxx-soc-devices.patch. Please check my fixup:
--- a/drivers/mmc/host/sdhci-cns3xxx.c~sdhci-s3c-add-support-for-the-non-standard-minimal-clock-value-fix
+++ a/drivers/mmc/host/sdhci-cns3xxx.c
@@ -93,5 +93,6 @@ struct sdhci_pltfm_data sdhci_cns3xxx_pd
SDHCI_QUIRK_INVERTED_WRITE_PROTECT |
SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN |
SDHCI_QUIRK_BROKEN_TIMEOUT_VAL |
+ SDHCI_QUIRK_NONSTANDARD_MINCLOCK |
SDHCI_QUIRK_NONSTANDARD_CLOCK,
};
next prev parent reply other threads:[~2010-07-09 21:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 6:49 [PATCH v2] SDHCI-S3C fixes and enhancements (driver specific code) Marek Szyprowski
2010-06-16 6:49 ` [PATCH 1/3] sdhci-s3c: add missing remove function Marek Szyprowski
2010-07-09 21:26 ` Andrew Morton
2010-07-12 11:04 ` Marek Szyprowski
2010-07-12 23:52 ` Andrew Morton
2010-06-16 6:49 ` [PATCH 2/3] sdhci-s3c: add support for the non standard minimal clock value Marek Szyprowski
2010-07-09 21:19 ` Andrew Morton [this message]
2010-07-12 10:16 ` Marek Szyprowski
2010-06-16 6:49 ` [PATCH 3/3] sdhci-s3c: add support for new card detection methods Marek Szyprowski
2010-07-09 21:24 ` Andrew Morton
2010-07-12 11:04 ` Marek Szyprowski
2010-07-12 12:59 ` [PATCH v3] " Marek Szyprowski
2010-07-06 5:29 ` [PATCH v2] SDHCI-S3C fixes and enhancements (driver specific code) Kyungmin Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100709141903.d883ad05.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).