linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: pieterg@gmx.com (pieterg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/5] colibri-pxa3xx: add touchscreen support
Date: Fri, 9 Jul 2010 18:47:59 +0200	[thread overview]
Message-ID: <201007091847.59787.pieterg@gmx.com> (raw)
In-Reply-To: <201007091814.25040.arnd@arndb.de>

On Friday 09 July 2010 18:14:24 Arnd Bergmann wrote:
> On Friday 09 July 2010, pieterg wrote:
> > > > --- a/arch/arm/mach-pxa/include/mach/colibri.h
> > > > +++ b/arch/arm/mach-pxa/include/mach/colibri.h
> > > > @@ -30,6 +30,12 @@ extern void colibri_pxa3xx_init_nand(void);
> > > >  static inline void colibri_pxa3xx_init_nand(void) {}
> > > >  #endif
> > > >
> > > > +#if defined(CONFIG_INPUT_TOUCHSCREEN)
> > > > +extern void colibri_pxa3xx_init_touchscreen(void);
> > > > +#else
> > > > +static inline void colibri_pxa3xx_init_touchscreen(void) {}
> > > > +#endif
> > > > +
> > > >  /* physical memory regions */
> > > >  #define COLIBRI_SDRAM_BASE 0xa0000000      /* SDRAM region */
> > >
> > > What will happen if both of the TS devices are selected?
> >
> > That's no problem.
> > I actually have both configs enabled, so I can run the same kernel on
> > the 310 (which is using wm97 for a while now) and the 320 (which still
> > has ucb1400 at the moment)
>
> But doesn't the code still create both devices in /sys/devices/platform
> then? AFAICT, there is no runtime probing support to make sure you only
> register the device that is there.

Yes, they both show up. But at least the do not conflict, and only the 
detected device will register an input device.

  reply	other threads:[~2010-07-09 16:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08 20:49 [PATCH v2 5/5] colibri-pxa3xx: add touchscreen support pieterg
2010-07-08 23:03 ` Marek Vasut
2010-07-09  7:03   ` pieterg
2010-07-09 13:32     ` Marek Vasut
2010-07-09 16:14     ` Arnd Bergmann
2010-07-09 16:47       ` pieterg [this message]
2010-07-09 16:53         ` Arnd Bergmann
2010-07-09 17:21           ` pieterg
2010-07-09 17:25             ` Arnd Bergmann
2010-07-09  7:18 ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201007091847.59787.pieterg@gmx.com \
    --to=pieterg@gmx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).