From: cbouatmailru@gmail.com (Anton Vorontsov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/3] s3c24xx: iPAQ rx1950 series
Date: Tue, 13 Jul 2010 19:13:10 +0400 [thread overview]
Message-ID: <20100713151310.GA12234@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1278781069-30521-1-git-send-email-anarsoul@gmail.com>
On Sat, Jul 10, 2010 at 07:57:46PM +0300, Vasily Khoruzhick wrote:
> This patch series adds more support for iPAQ rx1950 PDA to linux:
> 1. LEDs driver -- it controls blue, green and red LEDs on rx1950
> 2. Battery driver -- adds ability to monitor and charge battery.
> This driver is suitable for H1940 PDA aswell (just need to write
> some machine specific callbacks and get voltage LUTs)
>
> v2: removed ac registration from s3c_adc_battery driver, use
> pda_power instead for ac support.
>
> P.S. I prefer to keep own LED triggers for s3c_adc_battery as
> generic power supply triggers do not support LED_HALF brightness
> (on h1940/rx1950 it's used for blink) and I want to keep same
> LEDs behavior as in WinMo.
No, please. Factor out LED triggers addition into a separate patch
and we will discuss* it. That way it won't block this driver merge.
Thanks,
* IIRC, using LED_HALF for blinking is wrong, see
drivers/leds/leds-pwm.c for a preferred approach.
--
Anton Vorontsov
email: cbouatmailru at gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2010-07-13 15:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-10 16:57 [PATCH v2 0/3] s3c24xx: iPAQ rx1950 series Vasily Khoruzhick
2010-07-10 16:57 ` [PATCH v2 1/3] rx1950: add rx1950 LEDs driver Vasily Khoruzhick
2010-07-10 16:57 ` [PATCH v2 2/3] Add s3c-adc-battery driver Vasily Khoruzhick
2010-07-13 18:27 ` Anton Vorontsov
2010-07-10 16:57 ` [PATCH v2 3/3] rx1950: add battery support Vasily Khoruzhick
2010-07-12 13:28 ` [PATCH v2 0/3] s3c24xx: iPAQ rx1950 series Vasily Khoruzhick
2010-07-13 15:13 ` Anton Vorontsov [this message]
2010-07-13 15:45 ` Vasily Khoruzhick
2010-07-13 15:58 ` Mark Brown
2010-07-13 17:05 ` Vasily Khoruzhick
2010-07-13 18:03 ` Mark Brown
2010-07-13 18:29 ` Vasily Khoruzhick
2010-07-13 20:08 ` Mark Brown
2010-07-13 20:11 ` Vasily Khoruzhick
2010-07-13 16:27 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100713151310.GA12234@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).