linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: anarsoul@gmail.com (Vasily Khoruzhick)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/3] s3c24xx: iPAQ rx1950 series
Date: Tue, 13 Jul 2010 18:45:04 +0300	[thread overview]
Message-ID: <201007131845.10426.anarsoul@gmail.com> (raw)
In-Reply-To: <20100713151310.GA12234@oksana.dev.rtsoft.ru>

? ????????? ?? 13 ???? 2010 18:13:10 ????? Anton Vorontsov ???????:

> No, please. Factor out LED triggers addition into a separate patch
> and we will discuss* it. That way it won't block this driver merge.

I'm not in hurry :) it's just my hobby, and I really don't care _when_ this 
driver will be merged. But I want it to be merged with all functionality 
(getting status/charging/LEDs).

> * IIRC, using LED_HALF for blinking is wrong, see
>   drivers/leds/leds-pwm.c for a preferred approach.

Then it needs complex trigger, so anyway generic power supply simple triggers 
do not fit in my case. Btw, some LEDs drivers in mainline kernels use LED_HALF 
for blinking, i.e. leds-pca955x.c and leds-h1940.c.

Regards
Vasily
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100713/70e2cf95/attachment.sig>

  reply	other threads:[~2010-07-13 15:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-10 16:57 [PATCH v2 0/3] s3c24xx: iPAQ rx1950 series Vasily Khoruzhick
2010-07-10 16:57 ` [PATCH v2 1/3] rx1950: add rx1950 LEDs driver Vasily Khoruzhick
2010-07-10 16:57 ` [PATCH v2 2/3] Add s3c-adc-battery driver Vasily Khoruzhick
2010-07-13 18:27   ` Anton Vorontsov
2010-07-10 16:57 ` [PATCH v2 3/3] rx1950: add battery support Vasily Khoruzhick
2010-07-12 13:28 ` [PATCH v2 0/3] s3c24xx: iPAQ rx1950 series Vasily Khoruzhick
2010-07-13 15:13 ` Anton Vorontsov
2010-07-13 15:45   ` Vasily Khoruzhick [this message]
2010-07-13 15:58     ` Mark Brown
2010-07-13 17:05       ` Vasily Khoruzhick
2010-07-13 18:03         ` Mark Brown
2010-07-13 18:29           ` Vasily Khoruzhick
2010-07-13 20:08             ` Mark Brown
2010-07-13 20:11               ` Vasily Khoruzhick
2010-07-13 16:27     ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201007131845.10426.anarsoul@gmail.com \
    --to=anarsoul@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).