From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] mx51_3ds: Add support for the imx51 3-stack board
Date: Wed, 14 Jul 2010 15:33:39 +0200 [thread overview]
Message-ID: <20100714133339.GC18343@pengutronix.de> (raw)
In-Reply-To: <1279026162-6634-2-git-send-email-jason77.wang@gmail.com>
Hi Jason,
On Tue, Jul 13, 2010 at 09:02:39PM +0800, Jason Wang wrote:
> new file mode 100644
> index 0000000..b51da63
> --- /dev/null
> +++ b/arch/arm/mach-mx5/board-mx51_3ds.c
> @@ -0,0 +1,102 @@
> +/*
> + * Copyright 2008-2009 Freescale Semiconductor, Inc. All Rights Reserved.
> + * Copyright (C) 2010 Jason Wang <jason77.wang@gmail.com>
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
I think this is the usual FSL boiler plate, but IMHO this is bogus.
You/they want to have the "version 2 or later" part in the first
senctence, not the second.
(Note, this shouldn't be a nack, just a general comment.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-07-14 13:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 13:02 [PATCH 0/3]Add imx51_3ds platform support Jason Wang
2010-07-13 13:02 ` [PATCH 1/3] mx51_3ds: Add support for the imx51 3-stack board Jason Wang
2010-07-13 13:02 ` [PATCH 2/3] mx51: add imx_keypad device definition for mx51 platforms Jason Wang
2010-07-13 13:02 ` [PATCH 3/3] mx51_3ds: add keypad support on 3ds platform Jason Wang
2010-07-13 13:02 ` [PATCH] imx: move gpio init after to irq init Jason Wang
2010-07-13 14:24 ` Amit Kucheria
2010-07-23 14:02 ` Eric Bénard
2010-07-14 6:56 ` [PATCH 1/3] mx51_3ds: Add support for the imx51 3-stack board Sascha Hauer
2010-07-14 13:33 ` Uwe Kleine-König [this message]
2010-07-13 14:39 ` [PATCH 0/3]Add imx51_3ds platform support Amit Kucheria
2010-07-14 6:58 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100714133339.GC18343@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).