* [PATCH] ARM/nuc900: fix nuc900 touchscreen clk definition bug
@ 2010-07-16 3:03 Wan ZongShun
2010-07-16 5:09 ` Marek Vasut
2010-07-18 9:00 ` Russell King - ARM Linux
0 siblings, 2 replies; 6+ messages in thread
From: Wan ZongShun @ 2010-07-16 3:03 UTC (permalink / raw)
To: linux-arm-kernel
This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's
name should be 'nuc900-ts', it should be the same to pdev.name. or else,
the touchscreen driver will be not working well due to clock engine disabled.
Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
---
arch/arm/mach-w90x900/cpu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-w90x900/cpu.c b/arch/arm/mach-w90x900/cpu.c
index 642207e..83c5632 100644
--- a/arch/arm/mach-w90x900/cpu.c
+++ b/arch/arm/mach-w90x900/cpu.c
@@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = {
DEF_CLKLOOK(&clk_kpi, "nuc900-kpi", NULL),
DEF_CLKLOOK(&clk_wdt, "nuc900-wdt", NULL),
DEF_CLKLOOK(&clk_gdma, "nuc900-gdma", NULL),
- DEF_CLKLOOK(&clk_adc, "nuc900-adc", NULL),
+ DEF_CLKLOOK(&clk_adc, "nuc900-ts", NULL),
DEF_CLKLOOK(&clk_usi, "nuc900-spi", NULL),
DEF_CLKLOOK(&clk_ext, NULL, "ext"),
DEF_CLKLOOK(&clk_timer0, NULL, "timer0"),
--
1.6.3.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM/nuc900: fix nuc900 touchscreen clk definition bug
2010-07-16 3:03 [PATCH] ARM/nuc900: fix nuc900 touchscreen clk definition bug Wan ZongShun
@ 2010-07-16 5:09 ` Marek Vasut
2010-07-16 5:34 ` Wan ZongShun
2010-07-18 9:00 ` Russell King - ARM Linux
1 sibling, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2010-07-16 5:09 UTC (permalink / raw)
To: linux-arm-kernel
Dne P? 16. ?ervence 2010 05:03:27 Wan ZongShun napsal(a):
> This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's
> name should be 'nuc900-ts', it should be the same to pdev.name. or else,
> the touchscreen driver will be not working well due to clock engine
> disabled.
>
> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
> ---
> arch/arm/mach-w90x900/cpu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-w90x900/cpu.c b/arch/arm/mach-w90x900/cpu.c
> index 642207e..83c5632 100644
> --- a/arch/arm/mach-w90x900/cpu.c
> +++ b/arch/arm/mach-w90x900/cpu.c
> @@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = {
> DEF_CLKLOOK(&clk_kpi, "nuc900-kpi", NULL),
> DEF_CLKLOOK(&clk_wdt, "nuc900-wdt", NULL),
> DEF_CLKLOOK(&clk_gdma, "nuc900-gdma", NULL),
> - DEF_CLKLOOK(&clk_adc, "nuc900-adc", NULL),
> + DEF_CLKLOOK(&clk_adc, "nuc900-ts", NULL),
> DEF_CLKLOOK(&clk_usi, "nuc900-spi", NULL),
> DEF_CLKLOOK(&clk_ext, NULL, "ext"),
> DEF_CLKLOOK(&clk_timer0, NULL, "timer0"),
Hey,
Is that thing really touchscreen or general-purpose analog/digital converter ?
Cheers
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM/nuc900: fix nuc900 touchscreen clk definition bug
2010-07-16 5:09 ` Marek Vasut
@ 2010-07-16 5:34 ` Wan ZongShun
2010-07-16 7:19 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Wan ZongShun @ 2010-07-16 5:34 UTC (permalink / raw)
To: linux-arm-kernel
2010/7/16 Marek Vasut <marek.vasut@gmail.com>:
> Dne P? 16. ?ervence 2010 05:03:27 Wan ZongShun napsal(a):
>> This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's
>> name should be 'nuc900-ts', it should be the same to pdev.name. or else,
>> the touchscreen driver will be not working well due to clock engine
>> disabled.
>>
>> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
>> ---
>> ?arch/arm/mach-w90x900/cpu.c | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-w90x900/cpu.c b/arch/arm/mach-w90x900/cpu.c
>> index 642207e..83c5632 100644
>> --- a/arch/arm/mach-w90x900/cpu.c
>> +++ b/arch/arm/mach-w90x900/cpu.c
>> @@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = {
>> ? ? ? DEF_CLKLOOK(&clk_kpi, "nuc900-kpi", NULL),
>> ? ? ? DEF_CLKLOOK(&clk_wdt, "nuc900-wdt", NULL),
>> ? ? ? DEF_CLKLOOK(&clk_gdma, "nuc900-gdma", NULL),
>> - ? ? DEF_CLKLOOK(&clk_adc, "nuc900-adc", NULL),
>> + ? ? DEF_CLKLOOK(&clk_adc, "nuc900-ts", NULL),
>> ? ? ? DEF_CLKLOOK(&clk_usi, "nuc900-spi", NULL),
>> ? ? ? DEF_CLKLOOK(&clk_ext, NULL, "ext"),
>> ? ? ? DEF_CLKLOOK(&clk_timer0, NULL, "timer0"),
>
> Hey,
>
> Is that thing really touchscreen or general-purpose analog/digital converter ?
>
Oh, it is general-purpose analog/digital converter controller.
I only use it to implemnt my touchscreen function, Also it can be use
other function.
so, I have to change my touchscreen driver name to nuc900-adc?
Thanks for your Reminder, I appreciate it. :)
> Cheers
>
--
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel at lists.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
* linux-arm-NUC900 mailing list
mail addr:NUC900 at googlegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com at gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM/nuc900: fix nuc900 touchscreen clk definition bug
2010-07-16 5:34 ` Wan ZongShun
@ 2010-07-16 7:19 ` Marek Vasut
2010-07-16 9:11 ` Wan ZongShun
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2010-07-16 7:19 UTC (permalink / raw)
To: linux-arm-kernel
Dne P? 16. ?ervence 2010 07:34:21 Wan ZongShun napsal(a):
> 2010/7/16 Marek Vasut <marek.vasut@gmail.com>:
> > Dne P? 16. ?ervence 2010 05:03:27 Wan ZongShun napsal(a):
> >> This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's
> >> name should be 'nuc900-ts', it should be the same to pdev.name. or else,
> >> the touchscreen driver will be not working well due to clock engine
> >> disabled.
> >>
> >> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
> >> ---
> >> arch/arm/mach-w90x900/cpu.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-w90x900/cpu.c b/arch/arm/mach-w90x900/cpu.c
> >> index 642207e..83c5632 100644
> >> --- a/arch/arm/mach-w90x900/cpu.c
> >> +++ b/arch/arm/mach-w90x900/cpu.c
> >> @@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = {
> >> DEF_CLKLOOK(&clk_kpi, "nuc900-kpi", NULL),
> >> DEF_CLKLOOK(&clk_wdt, "nuc900-wdt", NULL),
> >> DEF_CLKLOOK(&clk_gdma, "nuc900-gdma", NULL),
> >> - DEF_CLKLOOK(&clk_adc, "nuc900-adc", NULL),
> >> + DEF_CLKLOOK(&clk_adc, "nuc900-ts", NULL),
> >> DEF_CLKLOOK(&clk_usi, "nuc900-spi", NULL),
> >> DEF_CLKLOOK(&clk_ext, NULL, "ext"),
> >> DEF_CLKLOOK(&clk_timer0, NULL, "timer0"),
> >
> > Hey,
> >
> > Is that thing really touchscreen or general-purpose analog/digital
> > converter ?
>
> Oh, it is general-purpose analog/digital converter controller.
> I only use it to implemnt my touchscreen function, Also it can be use
> other function.
>
> so, I have to change my touchscreen driver name to nuc900-adc?
No, just change the name of clock in the touchscreen driver. So that the
touchscreen driver will use nuc900-adc clocksource.
You're welcome. :)
>
> Thanks for your Reminder, I appreciate it. :)
>
> > Cheers
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM/nuc900: fix nuc900 touchscreen clk definition bug
2010-07-16 7:19 ` Marek Vasut
@ 2010-07-16 9:11 ` Wan ZongShun
0 siblings, 0 replies; 6+ messages in thread
From: Wan ZongShun @ 2010-07-16 9:11 UTC (permalink / raw)
To: linux-arm-kernel
2010/7/16 Marek Vasut <marek.vasut@gmail.com>:
> Dne P? 16. ?ervence 2010 07:34:21 Wan ZongShun napsal(a):
>> 2010/7/16 Marek Vasut <marek.vasut@gmail.com>:
>> > Dne P? 16. ?ervence 2010 05:03:27 Wan ZongShun napsal(a):
>> >> This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's
>> >> name should be 'nuc900-ts', it should be the same to pdev.name. or else,
>> >> the touchscreen driver will be not working well due to clock engine
>> >> disabled.
>> >>
>> >> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
>> >> ---
>> >> ?arch/arm/mach-w90x900/cpu.c | ? ?2 +-
>> >> ?1 files changed, 1 insertions(+), 1 deletions(-)
>> >>
>> >> diff --git a/arch/arm/mach-w90x900/cpu.c b/arch/arm/mach-w90x900/cpu.c
>> >> index 642207e..83c5632 100644
>> >> --- a/arch/arm/mach-w90x900/cpu.c
>> >> +++ b/arch/arm/mach-w90x900/cpu.c
>> >> @@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = {
>> >> ? ? ? DEF_CLKLOOK(&clk_kpi, "nuc900-kpi", NULL),
>> >> ? ? ? DEF_CLKLOOK(&clk_wdt, "nuc900-wdt", NULL),
>> >> ? ? ? DEF_CLKLOOK(&clk_gdma, "nuc900-gdma", NULL),
>> >> - ? ? DEF_CLKLOOK(&clk_adc, "nuc900-adc", NULL),
>> >> + ? ? DEF_CLKLOOK(&clk_adc, "nuc900-ts", NULL),
>> >> ? ? ? DEF_CLKLOOK(&clk_usi, "nuc900-spi", NULL),
>> >> ? ? ? DEF_CLKLOOK(&clk_ext, NULL, "ext"),
>> >> ? ? ? DEF_CLKLOOK(&clk_timer0, NULL, "timer0"),
>> >
>> > Hey,
>> >
>> > Is that thing really touchscreen or general-purpose analog/digital
>> > converter ?
>>
>> Oh, it is general-purpose analog/digital converter controller.
>> I only use it to implemnt my touchscreen function, Also it can be use
>> other function.
>>
>> so, I have to change my touchscreen driver name to nuc900-adc?
>
> No, just change the name of clock in the touchscreen driver. So that the
> touchscreen driver will use nuc900-adc clocksource.
But the clk_get() identifies this clk via looking driver or pdev name.
so I must change my touchscreen driver name, right?
>
> You're welcome. :)
>
>>
>> Thanks for your Reminder, I appreciate it. :)
>>
>> > Cheers
>
--
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel at lists.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
* linux-arm-NUC900 mailing list
mail addr:NUC900 at googlegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com at gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM/nuc900: fix nuc900 touchscreen clk definition bug
2010-07-16 3:03 [PATCH] ARM/nuc900: fix nuc900 touchscreen clk definition bug Wan ZongShun
2010-07-16 5:09 ` Marek Vasut
@ 2010-07-18 9:00 ` Russell King - ARM Linux
1 sibling, 0 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2010-07-18 9:00 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 16, 2010 at 11:03:27AM +0800, Wan ZongShun wrote:
> This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's
> name should be 'nuc900-ts', it should be the same to pdev.name. or else,
> the touchscreen driver will be not working well due to clock engine disabled.
Ok.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-07-18 9:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-16 3:03 [PATCH] ARM/nuc900: fix nuc900 touchscreen clk definition bug Wan ZongShun
2010-07-16 5:09 ` Marek Vasut
2010-07-16 5:34 ` Wan ZongShun
2010-07-16 7:19 ` Marek Vasut
2010-07-16 9:11 ` Wan ZongShun
2010-07-18 9:00 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).