public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] arm/ns9xxx: fix debug macro compilation failure
Date: Thu, 22 Jul 2010 11:38:34 +0100	[thread overview]
Message-ID: <20100722103834.GH31293@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1279074759.519643.866429356172.5.gpush@pororo>

On Wed, Jul 14, 2010 at 10:32:39AM +0800, Jeremy Kerr wrote:
> We need mach/memory.h for NS9XXX_CSxSTAT_PHYS, and mach/memory.h needs
> asm/memory.h for UL().

NAK.  Definitely NAK.  You haven't checked what includes whatelse.

asm/memory.h includes mach/memory.h to pick up the platform specific
parts, and provides mach/memory.h with its pre-requisits.  Use asm/memory.h
_everywhere_ rather than mach/memory.h.

Doing otherwise will create include loops, which leads to unreliability
in defined symbols.

  reply	other threads:[~2010-07-22 10:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-14  2:32 [PATCH 0/6] debug macro fixups Jeremy Kerr
2010-07-14  2:32 ` [PATCH 1/6] arm/clps711x: fix debug macro compilation failure Jeremy Kerr
2010-07-14  2:32 ` [PATCH 2/6] arm/h720x: " Jeremy Kerr
2010-07-14  2:32 ` [PATCH 5/6] arm/ns9xxx: " Jeremy Kerr
2010-07-22 10:38   ` Russell King - ARM Linux [this message]
2010-07-22 10:50     ` Eric Miao
2010-07-22 10:55       ` Russell King - ARM Linux
2010-07-22 14:05     ` [PATCH v2] " Jeremy Kerr
2010-07-22 14:10       ` Russell King - ARM Linux
2010-07-14  2:32 ` [PATCH 4/6] arm/plat-spear: " Jeremy Kerr
2010-07-14  2:32 ` [PATCH 6/6] arm/shark: " Jeremy Kerr
2010-07-22 10:36   ` Russell King - ARM Linux
2010-07-14  2:32 ` [PATCH 3/6] arm/l7200: " Jeremy Kerr
2010-07-14  2:39 ` [PATCH 0/6] debug macro fixups Jeremy Kerr
2010-07-14  3:40   ` Nicolas Pitre
2010-07-14  7:31     ` Jeremy Kerr
2010-07-14  5:31 ` Baruch Siach
2010-07-22 10:39 ` Russell King - ARM Linux
2010-07-22 15:36   ` Jeremy Kerr
  -- strict thread matches above, loose matches on Subject: below --
2010-07-14  7:29 [PATCH 0/6] debug macro fixups, v2 Jeremy Kerr
2010-07-14  7:29 ` [PATCH 5/6] arm/ns9xxx: fix debug macro compilation failure Jeremy Kerr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100722103834.GH31293@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox