From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: Pull request mxc
Date: Mon, 26 Jul 2010 14:00:08 +0200 [thread overview]
Message-ID: <20100726120008.GR14113@pengutronix.de> (raw)
In-Reply-To: <20100726103219.GB20737@n2100.arm.linux.org.uk>
[Added Guennadi, Baruch and linux-media to cc]
On Mon, Jul 26, 2010 at 11:32:19AM +0100, Russell King - ARM Linux wrote:
> On Mon, Jul 26, 2010 at 10:28:55AM +0100, Russell King - ARM Linux wrote:
> > On Mon, Jul 26, 2010 at 11:00:14AM +0200, Sascha Hauer wrote:
> > > 160 files changed, 6547 insertions(+), 3276 deletions(-)
> >
> > I get:
> >
> > 160 files changed, 6530 insertions(+), 3265 deletions
> >
> > which seems to be down to this difference between your diffstat and mine:
> >
> > > arch/arm/mach-mx3/mach-mx31lilly.c | 48 +-
> >
> > arch/arm/mach-mx3/mach-mx31lilly.c | 20 +-
> >
> > This seems to be down to 4d5d859 (ARM: mx3: mx31lilly: fix build error for
> > !CONFIG_USB_ULPI).
>
> Err...
>
> commit 10ee61384e444133e4d2cf2a1f21fdd50c2be297
> Author: Baruch Siach <baruch@tkos.co.il>
> Date: Sun Jul 4 07:55:10 2010 +0300
>
> mx2_camera: Add soc_camera support for i.MX25/i.MX27
>
> This is the soc_camera support developed by Sascha Hauer for the i.MX27. Alan
> Carvalho de Assis modified the original driver to get it working on more recent
> kernels. I modified it further to add support for i.MX25. This driver has been
> tested on i.MX25 and i.MX27 based platforms.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> Why has no one from the V4L community reviewed this patch?
It was posted to linux-media and reviewed there. I put it in my tree to
prevent problems due to missing platform_data declarations when board
support for the camera gets added.
>
> Why are you using void __iomem * with the virtual address returned from
> dma_alloc_coherent()? It doesn't return IOMEM addresses!
Baruch, can you fix this?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2010-07-26 12:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 9:00 Pull request mxc Sascha Hauer
2010-07-26 9:28 ` Russell King - ARM Linux
2010-07-26 10:32 ` Russell King - ARM Linux
2010-07-26 12:00 ` Sascha Hauer [this message]
2010-07-26 13:46 ` Sascha Hauer
2010-07-28 7:44 ` Sascha Hauer
2010-07-27 5:09 ` Baruch Siach
2010-07-28 7:12 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100726120008.GR14113@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).