* [PATCH 2/6] S5PC210: OneNAND: Use the correct DMA address range
@ 2010-07-28 10:11 Kyungmin Park
2010-07-29 0:34 ` Kukjin Kim
0 siblings, 1 reply; 5+ messages in thread
From: Kyungmin Park @ 2010-07-28 10:11 UTC (permalink / raw)
To: linux-arm-kernel
From: Kyungmin Park <kyungmin.park@samsung.com>
OneNAND DMA SFR requires the 8KiB mapping.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/plat-s5p/dev-onenand.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-s5p/dev-onenand.c b/arch/arm/plat-s5p/dev-onenand.c
index 08b3a3f..4d3eddb 100644
--- a/arch/arm/plat-s5p/dev-onenand.c
+++ b/arch/arm/plat-s5p/dev-onenand.c
@@ -30,7 +30,7 @@ static struct resource s5pc110_onenand_resources[] = {
},
[1] = {
.start = S5PC110_PA_ONENAND_DMA,
- .end = S5PC110_PA_ONENAND_DMA + SZ_2K - 1,
+ .end = S5PC110_PA_ONENAND_DMA + SZ_8K - 1,
.flags = IORESOURCE_MEM,
},
};
--
1.5.3.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/6] S5PC210: OneNAND: Use the correct DMA address range
2010-07-28 10:11 [PATCH 2/6] S5PC210: OneNAND: Use the correct DMA address range Kyungmin Park
@ 2010-07-29 0:34 ` Kukjin Kim
2010-07-30 0:31 ` Kyungmin Park
0 siblings, 1 reply; 5+ messages in thread
From: Kukjin Kim @ 2010-07-29 0:34 UTC (permalink / raw)
To: linux-arm-kernel
Kyungmin Park wrote:
>
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> OneNAND DMA SFR requires the 8KiB mapping.
>
It would be helpful if you could add the reason why should change.
Just fix the DMA address range? Or for support further SoCs?...
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-s5p/dev-onenand.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-s5p/dev-onenand.c
b/arch/arm/plat-s5p/dev-onenand.c
> index 08b3a3f..4d3eddb 100644
> --- a/arch/arm/plat-s5p/dev-onenand.c
> +++ b/arch/arm/plat-s5p/dev-onenand.c
> @@ -30,7 +30,7 @@ static struct resource s5pc110_onenand_resources[] = {
> },
> [1] = {
> .start = S5PC110_PA_ONENAND_DMA,
> - .end = S5PC110_PA_ONENAND_DMA + SZ_2K - 1,
> + .end = S5PC110_PA_ONENAND_DMA + SZ_8K - 1,
> .flags = IORESOURCE_MEM,
> },
> };
> --
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 2/6] S5PC210: OneNAND: Use the correct DMA address range
2010-07-29 0:34 ` Kukjin Kim
@ 2010-07-30 0:31 ` Kyungmin Park
2010-07-30 1:18 ` Kukjin Kim
0 siblings, 1 reply; 5+ messages in thread
From: Kyungmin Park @ 2010-07-30 0:31 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jul 29, 2010 at 9:34 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Kyungmin Park wrote:
>>
>> From: Kyungmin Park <kyungmin.park@samsung.com>
>>
>> OneNAND DMA SFR requires the 8KiB mapping.
>>
> It would be helpful if you could add the reason why should change.
>
> Just fix the DMA address range? Or for support further SoCs?...
Of course DMA address range.
In the spec, the final address is INTC_ONENAND_STATUS 0xB060_1068
Thank you,
Kyungmin Park
>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> ?arch/arm/plat-s5p/dev-onenand.c | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/plat-s5p/dev-onenand.c
> b/arch/arm/plat-s5p/dev-onenand.c
>> index 08b3a3f..4d3eddb 100644
>> --- a/arch/arm/plat-s5p/dev-onenand.c
>> +++ b/arch/arm/plat-s5p/dev-onenand.c
>> @@ -30,7 +30,7 @@ static struct resource s5pc110_onenand_resources[] = {
>> ? ? ? },
>> ? ? ? [1] = {
>> ? ? ? ? ? ? ? .start ?= S5PC110_PA_ONENAND_DMA,
>> - ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_2K - 1,
>> + ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_8K - 1,
>> ? ? ? ? ? ? ? .flags ?= IORESOURCE_MEM,
>> ? ? ? },
>> ?};
>> --
>
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 2/6] S5PC210: OneNAND: Use the correct DMA address range
2010-07-30 0:31 ` Kyungmin Park
@ 2010-07-30 1:18 ` Kukjin Kim
2010-07-30 2:43 ` Kyungmin Park
0 siblings, 1 reply; 5+ messages in thread
From: Kukjin Kim @ 2010-07-30 1:18 UTC (permalink / raw)
To: linux-arm-kernel
Kyungmin Park wrote:
>
> On Thu, Jul 29, 2010 at 9:34 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > Kyungmin Park wrote:
> >>
> >> From: Kyungmin Park <kyungmin.park@samsung.com>
> >>
> >> OneNAND DMA SFR requires the 8KiB mapping.
> >>
> > It would be helpful if you could add the reason why should change.
> >
> > Just fix the DMA address range? Or for support further SoCs?...
>
> Of course DMA address range.
>
> In the spec, the final address is INTC_ONENAND_STATUS 0xB060_1068
>
I meant should being the reason in the commit message.
Could not know correct reason by your comment. Ok...
> Thank you,
> Kyungmin Park
>
> >
> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >> ---
> >> ?arch/arm/plat-s5p/dev-onenand.c | ? ?2 +-
> >> ?1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/arch/arm/plat-s5p/dev-onenand.c
> > b/arch/arm/plat-s5p/dev-onenand.c
> >> index 08b3a3f..4d3eddb 100644
> >> --- a/arch/arm/plat-s5p/dev-onenand.c
> >> +++ b/arch/arm/plat-s5p/dev-onenand.c
> >> @@ -30,7 +30,7 @@ static struct resource s5pc110_onenand_resources[] =
{
> >> ? ? ? },
> >> ? ? ? [1] = {
> >> ? ? ? ? ? ? ? .start ?= S5PC110_PA_ONENAND_DMA,
> >> - ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_2K - 1,
> >> + ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_8K - 1,
> >> ? ? ? ? ? ? ? .flags ?= IORESOURCE_MEM,
> >> ? ? ? },
> >> ?};
> >> --
> >
> >
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 2/6] S5PC210: OneNAND: Use the correct DMA address range
2010-07-30 1:18 ` Kukjin Kim
@ 2010-07-30 2:43 ` Kyungmin Park
0 siblings, 0 replies; 5+ messages in thread
From: Kyungmin Park @ 2010-07-30 2:43 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 30, 2010 at 10:18 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Kyungmin Park wrote:
>>
>> On Thu, Jul 29, 2010 at 9:34 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>> > Kyungmin Park wrote:
>> >>
>> >> From: Kyungmin Park <kyungmin.park@samsung.com>
>> >>
>> >> OneNAND DMA SFR requires the 8KiB mapping.
>> >>
>> > It would be helpful if you could add the reason why should change.
>> >
>> > Just fix the DMA address range? Or for support further SoCs?...
>>
>> Of course DMA address range.
>>
>> In the spec, the final address is INTC_ONENAND_STATUS 0xB060_1068
>>
> I meant should being the reason in the commit message.
> Could not know correct reason by your comment. Ok...
Subject is "Use the correct DMA address range"
>
>> Thank you,
>> Kyungmin Park
>>
>> >
>> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> >> ---
>> >> ?arch/arm/plat-s5p/dev-onenand.c | ? ?2 +-
>> >> ?1 files changed, 1 insertions(+), 1 deletions(-)
>> >>
>> >> diff --git a/arch/arm/plat-s5p/dev-onenand.c
>> > b/arch/arm/plat-s5p/dev-onenand.c
>> >> index 08b3a3f..4d3eddb 100644
>> >> --- a/arch/arm/plat-s5p/dev-onenand.c
>> >> +++ b/arch/arm/plat-s5p/dev-onenand.c
>> >> @@ -30,7 +30,7 @@ static struct resource s5pc110_onenand_resources[] =
> {
>> >> ? ? ? },
>> >> ? ? ? [1] = {
>> >> ? ? ? ? ? ? ? .start ?= S5PC110_PA_ONENAND_DMA,
>> >> - ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_2K - 1,
>> >> + ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_8K - 1,
>> >> ? ? ? ? ? ? ? .flags ?= IORESOURCE_MEM,
>> >> ? ? ? },
>> >> ?};
>> >> --
>> >
>> >
>
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-07-30 2:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-28 10:11 [PATCH 2/6] S5PC210: OneNAND: Use the correct DMA address range Kyungmin Park
2010-07-29 0:34 ` Kukjin Kim
2010-07-30 0:31 ` Kyungmin Park
2010-07-30 1:18 ` Kukjin Kim
2010-07-30 2:43 ` Kyungmin Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).