linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 6/6] S5PV310: Enable the OneNAND at Universal board
@ 2010-07-28 10:12 Kyungmin Park
  2010-07-29  1:26 ` Kukjin Kim
  0 siblings, 1 reply; 2+ messages in thread
From: Kyungmin Park @ 2010-07-28 10:12 UTC (permalink / raw)
  To: linux-arm-kernel

From: Kyungmin Park <kyungmin.park@samsung.com>

Use the OneNAND at universal board

Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 arch/arm/mach-s5pv310/Kconfig          |    1 +
 arch/arm/mach-s5pv310/mach-universal.c |    8 ++++++++
 2 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-s5pv310/Kconfig b/arch/arm/mach-s5pv310/Kconfig
index 2fe8149..1bf780e 100644
--- a/arch/arm/mach-s5pv310/Kconfig
+++ b/arch/arm/mach-s5pv310/Kconfig
@@ -28,6 +28,7 @@ config MACH_UNIVERSAL
 	bool "Mobile Universal Board"
 	select CPU_S5PV310
 	select ARCH_SPARSEMEM_ENABLE
+	select S5PC110_DEV_ONENAND
 	help
 	  Machine support for Samsung Mobile Universal Reference Board.
 	  S5PC210(MCP) is one of package option of S5PV310
diff --git a/arch/arm/mach-s5pv310/mach-universal.c b/arch/arm/mach-s5pv310/mach-universal.c
index d22727f..371a95d 100644
--- a/arch/arm/mach-s5pv310/mach-universal.c
+++ b/arch/arm/mach-s5pv310/mach-universal.c
@@ -16,6 +16,7 @@
 #include <plat/regs-serial.h>
 #include <plat/s5pv310.h>
 #include <plat/cpu.h>
+#include <plat/devs.h>
 
 #include <mach/map.h>
 
@@ -60,6 +61,10 @@ static struct s3c2410_uartcfg universal_uartcfgs[] __initdata = {
 	},
 };
 
+static struct platform_device *universal_devices[] __initdata = {
+	&s5pc110_device_onenand,
+};
+
 static void __init universal_map_io(void)
 {
 	s5p_init_io(NULL, 0, S5P_VA_CHIPID);
@@ -72,6 +77,9 @@ static void __init universal_machine_init(void)
 #ifdef CONFIG_CACHE_L2X0
 	l2x0_init(S5P_VA_L2CC, 1 << 28, 0xffffffff);
 #endif
+
+	/* Last */
+	platform_add_devices(universal_devices, ARRAY_SIZE(universal_devices));
 }
 
 MACHINE_START(UNIVERSAL, "UNIVERSAL")
-- 
1.5.3.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 6/6] S5PV310: Enable the OneNAND at Universal board
  2010-07-28 10:12 [PATCH 6/6] S5PV310: Enable the OneNAND at Universal board Kyungmin Park
@ 2010-07-29  1:26 ` Kukjin Kim
  0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2010-07-29  1:26 UTC (permalink / raw)
  To: linux-arm-kernel

Kyungmin Park wrote:
> 
> From: Kyungmin Park <kyungmin.park@samsung.com>
> 
> Use the OneNAND at universal board

This patch needs previous adding board patch.
It doesn't mean that #5 patch should be in this patch set.

Just 'adding NOTE' about that is enough in here.

And in future please remember following items...

- If you want to submit patchset, please send #0 patch which includes
description of patches together.
- If you want to re-submit, please add changes...it can inform what should
review.
- Please include Ben Dooks in Cc.

> 
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  arch/arm/mach-s5pv310/Kconfig          |    1 +
>  arch/arm/mach-s5pv310/mach-universal.c |    8 ++++++++
>  2 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-s5pv310/Kconfig b/arch/arm/mach-s5pv310/Kconfig
> index 2fe8149..1bf780e 100644
> --- a/arch/arm/mach-s5pv310/Kconfig
> +++ b/arch/arm/mach-s5pv310/Kconfig
> @@ -28,6 +28,7 @@ config MACH_UNIVERSAL
>  	bool "Mobile Universal Board"
>  	select CPU_S5PV310
>  	select ARCH_SPARSEMEM_ENABLE
> +	select S5PC110_DEV_ONENAND
>  	help
>  	  Machine support for Samsung Mobile Universal Reference Board.
>  	  S5PC210(MCP) is one of package option of S5PV310
> diff --git a/arch/arm/mach-s5pv310/mach-universal.c b/arch/arm/mach-
> s5pv310/mach-universal.c
> index d22727f..371a95d 100644
> --- a/arch/arm/mach-s5pv310/mach-universal.c
> +++ b/arch/arm/mach-s5pv310/mach-universal.c
> @@ -16,6 +16,7 @@
>  #include <plat/regs-serial.h>
>  #include <plat/s5pv310.h>
>  #include <plat/cpu.h>
> +#include <plat/devs.h>
> 
>  #include <mach/map.h>
> 
> @@ -60,6 +61,10 @@ static struct s3c2410_uartcfg universal_uartcfgs[]
__initdata
> = {
>  	},
>  };
> 
> +static struct platform_device *universal_devices[] __initdata = {
> +	&s5pc110_device_onenand,
> +};
> +
>  static void __init universal_map_io(void)
>  {
>  	s5p_init_io(NULL, 0, S5P_VA_CHIPID);
> @@ -72,6 +77,9 @@ static void __init universal_machine_init(void)
>  #ifdef CONFIG_CACHE_L2X0
>  	l2x0_init(S5P_VA_L2CC, 1 << 28, 0xffffffff);
>  #endif
> +
> +	/* Last */

No need above comment.

> +	platform_add_devices(universal_devices,
> ARRAY_SIZE(universal_devices));
>  }
> 
>  MACHINE_START(UNIVERSAL, "UNIVERSAL")
> --


Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-07-29  1:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-28 10:12 [PATCH 6/6] S5PV310: Enable the OneNAND at Universal board Kyungmin Park
2010-07-29  1:26 ` Kukjin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).