linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] video/imxfb.c: allow usage without BACKLIGHT_CLASS_DEVICE
Date: Thu, 29 Jul 2010 11:11:38 +0200	[thread overview]
Message-ID: <20100729091138.GA6268@pengutronix.de> (raw)
In-Reply-To: <1280392978-25405-1-git-send-email-eric@eukrea.com>

On Thu, Jul 29, 2010 at 10:42:58AM +0200, Eric B?nard wrote:
> Signed-off-by: Eric B?nard <eric@eukrea.com>
> ---
>  drivers/video/imxfb.c |   13 +++++++++++--
>  1 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/imxfb.c b/drivers/video/imxfb.c
> index 43f0639..0c2fb4d 100644
> --- a/drivers/video/imxfb.c
> +++ b/drivers/video/imxfb.c
> @@ -175,7 +175,9 @@ struct imxfb_info {
>  
>  	struct imx_fb_videomode *mode;
>  	int			num_modes;
> +#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
>  	struct backlight_device *bl;
> +#endif
I'm always unsure about these .._MODULE symbols.  If imxfb and backlight
support both are compiled modular, is backlight support picked up if
#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE is used to guard it?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2010-07-29  9:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-16 13:09 [PATCH 1/3] eukrea_mbimxsd: factorize motherboard support Eric Bénard
2010-07-16 13:09 ` [PATCH 2/3] imx25: fix low level debug Eric Bénard
2010-07-16 13:09   ` [PATCH 3/3] imxfb: add pwmr controlled backlight support Eric Bénard
2010-07-29  5:16     ` Uwe Kleine-König
2010-07-29  8:42       ` [PATCH] video/imxfb.c: allow usage without BACKLIGHT_CLASS_DEVICE Eric Bénard
2010-07-29  9:11         ` Uwe Kleine-König [this message]
2010-07-29  9:47           ` [PATCH v2] " Eric Bénard
2010-07-29 12:45             ` Uwe Kleine-König
2010-07-29 13:03               ` Eric Bénard
2010-07-29 13:03               ` [PATCH v3] " Eric Bénard
2010-07-29 13:23                 ` Sergei Shtylyov
2010-07-29 13:33                   ` Eric Bénard
2010-07-29 14:17                   ` [PATCH v4] " Eric Bénard
2010-07-29 15:01                     ` Uwe Kleine-König
2010-08-02  7:39                       ` [PATCH] " Uwe Kleine-König
2010-07-29 13:37                 ` [PATCH v3] " Lothar Waßmann
2010-07-29  8:49       ` [PATCH 3/3] imxfb: add pwmr controlled backlight support Eric Bénard
2010-07-22 15:51 ` [PATCH 1/3] eukrea_mbimxsd: factorize motherboard support Uwe Kleine-König
  -- strict thread matches above, loose matches on Subject: below --
2010-07-29  8:42 [PATCH] video/imxfb.c: allow usage without BACKLIGHT_CLASS_DEVICE Eric Bénard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100729091138.GA6268@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).