linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix regression in RealView after the introduction of pclk
Date: Thu, 29 Jul 2010 23:21:14 +0100	[thread overview]
Message-ID: <20100729222114.GC28330@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <AANLkTi=xcFsL7vCtG31v0yWfkBV+vYqQZ4z=_p-=wZnH@mail.gmail.com>

On Thu, Jul 29, 2010 at 11:41:44PM +0200, Linus Walleij wrote:
> Yep that is true, currently. More like this then:

Yup - and the patch is a lot smaller.

> There is a reason why we have it on the interrupt init in ux500
> though, and that is that we want to use the clock framework to
> get the clock for the timer. If we want to fix up the hardcoded
> way it is currently done in plat-versatile/timer-sp.c we would need
> a change like this across the versatiles.

I don't think it makes sense to use the clk API for those timers -
it's rather unclear from the manuals where they get their clocks
from - or even what the magic bits in the system controller do in
terms of switching their clock source.

I've not found the magic bits which switch their clock source on
Versatile Express tiles yet either (which is why we're using the
V2M baseboard timers).

  reply	other threads:[~2010-07-29 22:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29 13:05 [PATCH] ARM: fix regression in RealView after the introduction of pclk Linus Walleij
2010-07-29 13:56 ` Russell King - ARM Linux
2010-07-29 21:41   ` Linus Walleij
2010-07-29 22:21     ` Russell King - ARM Linux [this message]
2010-07-30 15:27       ` Linus Walleij
2010-07-30 20:08         ` Russell King - ARM Linux
2010-07-30 23:12           ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100729222114.GC28330@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).