From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] fix Thumb-2 decompressor broken by "Auto calculate ZRELADDR"
Date: Fri, 30 Jul 2010 22:57:56 +0200 [thread overview]
Message-ID: <20100730205756.GA28316@pengutronix.de> (raw)
In-Reply-To: <1280518523-5526-1-git-send-email-rabin@rab.in>
On Sat, Jul 31, 2010 at 01:05:23AM +0530, Rabin Vincent wrote:
> "ARM: Auto calculate ZRELADDR and provide option for exceptions" broke the
> Thumb-2 decompressor because it removed an entry in the LC0 table but didn't
> adjust the offset the Thumb-2 code uses to load the SP from that table.
>
> Fix it, and also change the ARM code to use the separate SP-load since
> ARM instructions that include the SP in the LDM register list are
> deprecated.
I only found:
LDM{<cond>}<addressing_mode> <Rn>{!}, <registers>
...
If the base register <Rn> is specified in <registers>, and base
register write-back is specified,
the final value of <Rn> is UNPREDICTABLE.
Are you really sure about this? Where do you know it from?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-07-30 20:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 19:35 [PATCH] fix Thumb-2 decompressor broken by "Auto calculate ZRELADDR" Rabin Vincent
2010-07-30 20:57 ` Uwe Kleine-König [this message]
2010-07-30 23:44 ` Rabin Vincent
2010-07-31 9:04 ` Russell King - ARM Linux
2010-07-31 12:08 ` Uwe Kleine-König
2010-07-31 12:31 ` Russell King - ARM Linux
2010-07-31 12:50 ` Uwe Kleine-König
2010-08-03 0:40 ` [PATCHv2] " Rabin Vincent
2010-08-03 7:36 ` Uwe Kleine-König
2010-08-03 7:47 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100730205756.GA28316@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).