From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] fix Thumb-2 decompressor broken by "Auto calculate ZRELADDR"
Date: Sat, 31 Jul 2010 14:50:09 +0200 [thread overview]
Message-ID: <20100731125009.GA15412@pengutronix.de> (raw)
In-Reply-To: <20100731123142.GA27064@n2100.arm.linux.org.uk>
On Sat, Jul 31, 2010 at 01:31:42PM +0100, Russell King - ARM Linux wrote:
> On Sat, Jul 31, 2010 at 02:08:27PM +0200, Uwe Kleine-K?nig wrote:
> > On Sat, Jul 31, 2010 at 10:04:45AM +0100, Russell King - ARM Linux wrote:
> > > It doesn't matter. The point is that you deleted an entry from the
> > > table which the ldmia/ldmia+ldr loads from and didn't adjust the
> > > resulting code properly.
> > Yes, got that.
> > >
> > > - ARM( ldmia r0, {r1, r2, r3, r5, r6, r11, ip, sp})
> > > + ARM( ldmia r0, {r1, r2, r3, r5, r6, r11, ip})
> > > THUMB( ldmia r0, {r1, r2, r3, r5, r6, r11, ip} )
> > > - THUMB( ldr sp, [r0, #32] )
> > > + ldr sp, [r0, #28]
> > We can simpify this further to just
> >
> > @ Thumb code doesn't allow sp to be in the list, for ARM it's
> > @ deprecated, so use a seperate ldr for it.
> > ldmia r0, {r1, r2, r3, r5, r6, r11, ip}
> > ldr sp, [r0, #32]
>
> No, you mean #28.
oops, yes of course.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-07-31 12:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 19:35 [PATCH] fix Thumb-2 decompressor broken by "Auto calculate ZRELADDR" Rabin Vincent
2010-07-30 20:57 ` Uwe Kleine-König
2010-07-30 23:44 ` Rabin Vincent
2010-07-31 9:04 ` Russell King - ARM Linux
2010-07-31 12:08 ` Uwe Kleine-König
2010-07-31 12:31 ` Russell King - ARM Linux
2010-07-31 12:50 ` Uwe Kleine-König [this message]
2010-08-03 0:40 ` [PATCHv2] " Rabin Vincent
2010-08-03 7:36 ` Uwe Kleine-König
2010-08-03 7:47 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100731125009.GA15412@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).