From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/8] ARM: Samsung: Add register definitions for Samsung S5P SoC camera interface
Date: Mon, 2 Aug 2010 11:52:16 +0100 [thread overview]
Message-ID: <20100802105216.GD30670@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <003001cb322d$fc976b10$f5c64130$%osciak@samsung.com>
On Mon, Aug 02, 2010 at 12:32:20PM +0200, Pawel Osciak wrote:
> Well, some of them are indeed unused, but it's not an uncommon practice in
> kernel and might help future developers.
On the other hand, arch/arm is getting soo big that we need to do
something about this - and one solution is to avoid unnecessary
definitions that we're not using.
Another good idea is to put definitions along side the drivers which
they're relevant to - maybe in a local driver-name.h file which
driver-name.c includes, or maybe even within driver-name.c if they're
not excessive. This has the advantage of distributing the "bloat" to
where its actually used, and means that the driver isn't dependent so
much on arch/arm or even the SoC itself.
Take a look at arch/arm/mach-vexpress/include/mach/ct-ca9x4.h and
arch/arm/mach-vexpress/include/mach/motherboard.h - these are the only
two files which contain platform definitions which are actually used
for Versatile Express. Compare that with
arch/arm/mach-realview/include/mach/platform.h which contains lots
more...
next prev parent reply other threads:[~2010-08-02 10:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 16:21 [PATCH v3 0/8] Samsung S5P SoC camera interface driver Sylwester Nawrocki
2010-07-23 16:21 ` [PATCH v3 1/8] ARM: Samsung: Add register definitions for Samsung S5P SoC camera interface Sylwester Nawrocki
2010-07-26 6:51 ` Kukjin Kim
2010-08-02 10:32 ` Pawel Osciak
2010-08-02 10:52 ` Russell King - ARM Linux [this message]
2010-08-02 11:13 ` Marek Szyprowski
2010-08-02 11:51 ` Mauro Carvalho Chehab
2010-08-02 12:09 ` Russell King - ARM Linux
2010-08-02 12:08 ` Pawel Osciak
2010-08-02 16:58 ` Russell King - ARM Linux
2010-08-03 0:46 ` Kukjin Kim
2010-08-03 2:15 ` Kyungmin Park
2010-07-23 16:21 ` [PATCH v3 2/8] v4l: Add driver for Samsung S3C/S5P SoC video postprocessor Sylwester Nawrocki
2010-07-23 16:21 ` [PATCH v3 3/8] ARM: Samsung: Add platform definitions and helpers for FIMC driver Sylwester Nawrocki
2010-08-02 11:57 ` [PATCH v4 " Marek Szyprowski
2010-08-02 23:58 ` Kukjin Kim
2010-08-03 0:37 ` Kyungmin Park
2010-08-03 0:46 ` Kukjin Kim
2010-08-03 0:54 ` Kyungmin Park
2010-08-03 1:05 ` Kukjin Kim
2010-08-03 1:12 ` Kyungmin Park
2010-08-03 2:33 ` Kukjin Kim
2010-08-03 5:41 ` [PATCH v5 " Marek Szyprowski
2010-08-04 10:55 ` Kukjin Kim
2010-07-23 16:21 ` [PATCH v3 4/8] ARM: Samsung: Add common Aquila and GONI code Sylwester Nawrocki
2010-07-26 6:33 ` Kukjin Kim
2010-07-26 6:48 ` Pawel Osciak
2010-08-09 5:03 ` Kukjin Kim
2010-07-23 16:21 ` [PATCH v3 5/8] ARM: s5pv210: enable FIMC on Aquila Sylwester Nawrocki
2010-07-26 6:41 ` Kukjin Kim
2010-07-26 6:51 ` Pawel Osciak
2010-07-23 16:21 ` [PATCH v3 6/8] ARM: s5pv210: enable FIMC on Goni Sylwester Nawrocki
2010-07-23 16:21 ` [PATCH v3 7/8] ARM: S5PC100: enable FIMC on SMDKC100 Sylwester Nawrocki
2010-07-23 16:21 ` [PATCH v3 8/8] ARM: s5pv210: Override FIMC driver name on Aquila board Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100802105216.GD30670@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).