From: gregkh@suse.de (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb gadget: don't save bind callback in struct usb_gadget_driver
Date: Mon, 2 Aug 2010 15:54:40 -0700 [thread overview]
Message-ID: <20100802225440.GA9190@suse.de> (raw)
In-Reply-To: <20100802131248.GD13900@pengutronix.de>
On Mon, Aug 02, 2010 at 03:12:48PM +0200, Uwe Kleine-K?nig wrote:
> On Mon, Aug 02, 2010 at 02:51:36PM +0200, Julia Lawall wrote:
> > > diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
> > > index 731150d..c266c1e 100644
> > > --- a/drivers/usb/gadget/amd5536udc.c
> > > +++ b/drivers/usb/gadget/amd5536udc.c
> > > @@ -1954,13 +1954,14 @@ static int setup_ep0(struct udc *dev)
> > > }
> > >
> > > /* Called by gadget driver to register itself */
> > > -int usb_gadget_register_driver(struct usb_gadget_driver *driver)
> > > +int usb_gadget_probe_driver(struct usb_gadget_driver *driver,
> > > + int (*bind)(struct usb_gadget *))
> > > {
> > > struct udc *dev = udc;
> > > int retval;
> > > u32 tmp;
> > >
> > > - if (!driver || !driver->bind || !driver->setup
> > > + if (!driver || bind || !driver->setup
> >
> > I have the impression that this should be !bind rather than bind.
> ah, now I see what you meant. Obviously you're right. I fixed it up
> locally here for now. Greg, just tell me when/if you need a fixed
> patch.
Didn't you already post a "fixed" patch?
thanks,
greg k-h
next prev parent reply other threads:[~2010-08-02 22:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 14:49 [PATCH RFC] usb gadget: introduce usb_gadget_probe_driver Uwe Kleine-König
2010-07-30 15:14 ` Julia Lawall
2010-07-30 15:28 ` Uwe Kleine-König
2010-07-30 15:16 ` Michał Nazarewicz
2010-07-30 15:26 ` Uwe Kleine-König
2010-07-30 16:08 ` Michał Nazarewicz
2010-07-30 18:57 ` Uwe Kleine-König
2010-07-30 18:46 ` David Brownell
2010-08-02 9:39 ` Michał Nazarewicz
2010-08-02 12:39 ` [PATCH] usb gadget: don't save bind callback in struct usb_gadget_driver Uwe Kleine-König
2010-08-02 12:51 ` Julia Lawall
2010-08-02 13:12 ` Uwe Kleine-König
2010-08-02 22:54 ` Greg KH [this message]
2010-08-02 14:25 ` Michał Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100802225440.GA9190@suse.de \
--to=gregkh@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).