From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PXA: Fix wakealarm capability for pxa-rtc
Date: Tue, 3 Aug 2010 05:10:03 +0200 [thread overview]
Message-ID: <201008030510.03205.marek.vasut@gmail.com> (raw)
In-Reply-To: <20100803020328.1046308a@linux.lan.towertech.it>
Dne ?t 3. srpna 2010 02:03:28 Alessandro Zummo napsal(a):
> On Sun, 1 Aug 2010 17:38:16 +0200
>
> Marek Vasut <marek.vasut@gmail.com> wrote:
> > > As I see now your real
> > > problem, I would request you leave the existing "device_init_wakeup(x,
> > > 1)" *and* you add yours to make the class driver happy.
> >
> > Why wouldn't the driver wake up from suspend?
>
> may I see the latest version of your patch, Marek?
>
> ty
---
drivers/rtc/rtc-pxa.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c
index e9c6fa0..d76f187 100644
--- a/drivers/rtc/rtc-pxa.c
+++ b/drivers/rtc/rtc-pxa.c
@@ -403,6 +403,8 @@ static int __init pxa_rtc_probe(struct platform_device
*pdev)
rtsr_clear_bits(pxa_rtc, RTSR_PIALE | RTSR_RDALE1 | RTSR_HZE);
+ device_init_wakeup(dev, 1);
+
pxa_rtc->rtc = rtc_device_register("pxa-rtc", &pdev->dev, &pxa_rtc_ops,
THIS_MODULE);
ret = PTR_ERR(pxa_rtc->rtc);
@@ -411,8 +413,6 @@ static int __init pxa_rtc_probe(struct platform_device
*pdev)
goto err_rtc_reg;
}
- device_init_wakeup(dev, 1);
-
return 0;
err_rtc_reg:
--
1.7.1
next prev parent reply other threads:[~2010-08-03 3:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-31 4:22 [PATCH] PXA: Fix wakealarm capability for pxa-rtc Marek Vasut
2010-07-31 15:38 ` Robert Jarzmik
2010-07-31 20:15 ` Marek Vasut
2010-07-31 21:07 ` Robert Jarzmik
2010-08-01 0:13 ` Marek Vasut
2010-08-01 0:48 ` Robert Jarzmik
2010-08-01 0:53 ` Marek Vasut
2010-08-01 11:15 ` Robert Jarzmik
2010-08-01 15:38 ` Marek Vasut
2010-08-01 19:32 ` Robert Jarzmik
2010-08-03 0:03 ` Alessandro Zummo
2010-08-03 3:10 ` Marek Vasut [this message]
2010-08-06 19:59 ` Alessandro Zummo
2010-08-06 21:39 ` Marek Vasut
2010-08-07 9:43 ` Robert Jarzmik
2010-08-18 4:08 ` Eric Miao
2010-08-18 5:04 ` Marek Vasut
2010-08-18 6:15 ` Eric Miao
2010-08-01 8:42 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008030510.03205.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).