From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] fix Thumb-2 decompressor broken by "Auto calculate ZRELADDR"
Date: Tue, 3 Aug 2010 09:36:27 +0200 [thread overview]
Message-ID: <20100803073627.GA17297@pengutronix.de> (raw)
In-Reply-To: <1280796006-32028-1-git-send-email-rabin@rab.in>
Hello Rabin,
On Tue, Aug 03, 2010 at 06:10:06AM +0530, Rabin Vincent wrote:
> "ARM: Auto calculate ZRELADDR and provide option for exceptions" broke
> the Thumb-2 decompressor because it removed an entry in the LC0 table
> but didn't adjust the offset the Thumb-2 code uses to load the SP from
> that table.
>
> Fix it, and also change the ARM code to use the separate SP-load since
> ARM instructions that include the SP in the LDM register list are
> deprecated.
>
> Signed-off-by: Rabin Vincent <rabin@rab.in>
Acked-and-regretted-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
> ---
> v2: don't need separate code for ARM and THUMB since they're now
> the same.
>
> arch/arm/boot/compressed/head.S | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S
> index abf4d65..6af9907 100644
> --- a/arch/arm/boot/compressed/head.S
> +++ b/arch/arm/boot/compressed/head.S
> @@ -170,9 +170,8 @@ not_angel:
>
> .text
> adr r0, LC0
> - ARM( ldmia r0, {r1, r2, r3, r5, r6, r11, ip, sp})
> - THUMB( ldmia r0, {r1, r2, r3, r5, r6, r11, ip} )
> - THUMB( ldr sp, [r0, #32] )
> + ldmia r0, {r1, r2, r3, r5, r6, r11, ip}
> + ldr sp, [r0, #28]
> #ifdef CONFIG_AUTO_ZRELADDR
> @ determine final kernel image address
> and r4, pc, #0xf8000000
> --
> 1.7.1
>
>
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-08-03 7:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 19:35 [PATCH] fix Thumb-2 decompressor broken by "Auto calculate ZRELADDR" Rabin Vincent
2010-07-30 20:57 ` Uwe Kleine-König
2010-07-30 23:44 ` Rabin Vincent
2010-07-31 9:04 ` Russell King - ARM Linux
2010-07-31 12:08 ` Uwe Kleine-König
2010-07-31 12:31 ` Russell King - ARM Linux
2010-07-31 12:50 ` Uwe Kleine-König
2010-08-03 0:40 ` [PATCHv2] " Rabin Vincent
2010-08-03 7:36 ` Uwe Kleine-König [this message]
2010-08-03 7:47 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100803073627.GA17297@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).