* [PATCH 0/3] Allow late mdesc detection, v3
@ 2010-07-30 9:22 Jeremy Kerr
0 siblings, 0 replies; 4+ messages in thread
From: Jeremy Kerr @ 2010-07-30 9:22 UTC (permalink / raw)
To: linux-arm-kernel
Hi all,
Currently, we probe for a mdesc early in boot. At this early stage, the
only thing we use the mdesc for is to determine the debug page mapping.
However, the debug addresses (phys and virt) need to be coded into the
addruart macro anyway; the dynamic probing is only going to tell us what
we already know.
These changes allow us to use the addruart macros to find the debug
mapping addresses, rather than pulling them out of the mdesc. This means
that the addresses are only kept in the one place, and that we don't
need the mdesc nearly as early.
The first change updates all of the addruart macros to return both
physical and virtual addresses. I've used 'rp' and 'rv' as the macro
arguments to indicate which address goes where
The second change updates the debug setup routine to use the addruart
macro to establish the debug mapping, now that we can invoke the macro
to find the phyical and virtual addresses.
This allows us to delay the requirement to have a mdesc available until
much later. For example, we can parse one from the device tree once
we've reached C code.
May break OMAP1/2, as the addruart macros are more complex on these
platforms. I'd appreciate input from OMAP folks who may well tell me
that this isn't possible.
Cheers,
Jeremy
v3:
* only establish page mapping if !DEBUG_ICEDCC
v2:
* return both phys and virt addresses from addruart
* mask unneeded bits from uart physical address in mapping setup
* remove io_pg_offst and phys_io, in a separate patch
---
Jeremy Kerr (3):
arm/debug: consolidate addruart macros for CONFIG_DEBUG_ICEDCC
arm: return both physical and virtual addresses from addruart
arm: use addruart macro to establish debug mappings
^ permalink raw reply [flat|nested] 4+ messages in thread
* Fwd: [PATCH 0/3] Allow late mdesc detection, v3
@ 2010-07-31 9:25 Russell King - ARM Linux
2010-07-31 12:45 ` Shilimkar, Santosh
0 siblings, 1 reply; 4+ messages in thread
From: Russell King - ARM Linux @ 2010-07-31 9:25 UTC (permalink / raw)
To: linux-arm-kernel
Forwarding for OMAP people - as there's outstanding questions about this
change for their platforms.
----- Forwarded message from Jeremy Kerr <jeremy.kerr@canonical.com> -----
Date: Fri, 30 Jul 2010 17:22:11 +0800
From: Jeremy Kerr <jeremy.kerr@canonical.com>
To: linux-arm-kernel at lists.infradead.org
Subject: [PATCH 0/3] Allow late mdesc detection, v3
Delivery-date: Sat, 31 Jul 2010 01:25:58 +0100
Hi all,
Currently, we probe for a mdesc early in boot. At this early stage, the
only thing we use the mdesc for is to determine the debug page mapping.
However, the debug addresses (phys and virt) need to be coded into the
addruart macro anyway; the dynamic probing is only going to tell us what
we already know.
These changes allow us to use the addruart macros to find the debug
mapping addresses, rather than pulling them out of the mdesc. This means
that the addresses are only kept in the one place, and that we don't
need the mdesc nearly as early.
The first change updates all of the addruart macros to return both
physical and virtual addresses. I've used 'rp' and 'rv' as the macro
arguments to indicate which address goes where
The second change updates the debug setup routine to use the addruart
macro to establish the debug mapping, now that we can invoke the macro
to find the phyical and virtual addresses.
This allows us to delay the requirement to have a mdesc available until
much later. For example, we can parse one from the device tree once
we've reached C code.
May break OMAP1/2, as the addruart macros are more complex on these
platforms. I'd appreciate input from OMAP folks who may well tell me
that this isn't possible.
Cheers,
Jeremy
v3:
* only establish page mapping if !DEBUG_ICEDCC
v2:
* return both phys and virt addresses from addruart
* mask unneeded bits from uart physical address in mapping setup
* remove io_pg_offst and phys_io, in a separate patch
---
Jeremy Kerr (3):
arm/debug: consolidate addruart macros for CONFIG_DEBUG_ICEDCC
arm: return both physical and virtual addresses from addruart
arm: use addruart macro to establish debug mappings
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
----- End forwarded message -----
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 0/3] Allow late mdesc detection, v3
2010-07-31 9:25 Fwd: [PATCH 0/3] Allow late mdesc detection, v3 Russell King - ARM Linux
@ 2010-07-31 12:45 ` Shilimkar, Santosh
2010-08-03 12:56 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Shilimkar, Santosh @ 2010-07-31 12:45 UTC (permalink / raw)
To: linux-arm-kernel
Jeremy,
> -----Original Message-----
> From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-
> owner at vger.kernel.org] On Behalf Of Russell King - ARM Linux
> Sent: Saturday, July 31, 2010 2:55 PM
> To: linux-arm-kernel at lists.infradead.org; linux-omap at vger.kernel.org; Tony
> Lindgren
> Subject: Fwd: [PATCH 0/3] Allow late mdesc detection, v3
>
> Forwarding for OMAP people - as there's outstanding questions about this
> change for their platforms.
>
> ----- Forwarded message from Jeremy Kerr <jeremy.kerr@canonical.com> -----
>
> Date: Fri, 30 Jul 2010 17:22:11 +0800
> From: Jeremy Kerr <jeremy.kerr@canonical.com>
> To: linux-arm-kernel at lists.infradead.org
> Subject: [PATCH 0/3] Allow late mdesc detection, v3
> Delivery-date: Sat, 31 Jul 2010 01:25:58 +0100
>
> Hi all,
>
> Currently, we probe for a mdesc early in boot. At this early stage, the
> only thing we use the mdesc for is to determine the debug page mapping.
>
> However, the debug addresses (phys and virt) need to be coded into the
> addruart macro anyway; the dynamic probing is only going to tell us what
> we already know.
>
> These changes allow us to use the addruart macros to find the debug
> mapping addresses, rather than pulling them out of the mdesc. This means
> that the addresses are only kept in the one place, and that we don't
> need the mdesc nearly as early.
>
> The first change updates all of the addruart macros to return both
> physical and virtual addresses. I've used 'rp' and 'rv' as the macro
> arguments to indicate which address goes where
>
> The second change updates the debug setup routine to use the addruart
> macro to establish the debug mapping, now that we can invoke the macro
> to find the phyical and virtual addresses.
>
> This allows us to delay the requirement to have a mdesc available until
> much later. For example, we can parse one from the device tree once
> we've reached C code.
>
> May break OMAP1/2, as the addruart macros are more complex on these
> platforms. I'd appreciate input from OMAP folks who may well tell me
> that this isn't possible.
>
Just tried this on OMAP4, and indeed it breaks OMAP2PLUS low level debug
support.
Tony recently revamped the complete debug code, so that we can dynamically
set correct debug port based on machine ID passed by boot-loaders. Based
on this , the debug code determines the the correct debug port based on
this using a scratch pad register.
Tony can comment better on this issue.
Regards,
Santosh
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 0/3] Allow late mdesc detection, v3
2010-07-31 12:45 ` Shilimkar, Santosh
@ 2010-08-03 12:56 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2010-08-03 12:56 UTC (permalink / raw)
To: linux-arm-kernel
* Shilimkar, Santosh <santosh.shilimkar@ti.com> [100731 15:38]:
> Jeremy,
> > -----Original Message-----
> > From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-
> > owner at vger.kernel.org] On Behalf Of Russell King - ARM Linux
> > Sent: Saturday, July 31, 2010 2:55 PM
> > To: linux-arm-kernel at lists.infradead.org; linux-omap at vger.kernel.org; Tony
> > Lindgren
> > Subject: Fwd: [PATCH 0/3] Allow late mdesc detection, v3
> >
> > Forwarding for OMAP people - as there's outstanding questions about this
> > change for their platforms.
> >
> > ----- Forwarded message from Jeremy Kerr <jeremy.kerr@canonical.com> -----
> >
> > Date: Fri, 30 Jul 2010 17:22:11 +0800
> > From: Jeremy Kerr <jeremy.kerr@canonical.com>
> > To: linux-arm-kernel at lists.infradead.org
> > Subject: [PATCH 0/3] Allow late mdesc detection, v3
> > Delivery-date: Sat, 31 Jul 2010 01:25:58 +0100
> >
> > Hi all,
> >
> > Currently, we probe for a mdesc early in boot. At this early stage, the
> > only thing we use the mdesc for is to determine the debug page mapping.
> >
> > However, the debug addresses (phys and virt) need to be coded into the
> > addruart macro anyway; the dynamic probing is only going to tell us what
> > we already know.
> >
> > These changes allow us to use the addruart macros to find the debug
> > mapping addresses, rather than pulling them out of the mdesc. This means
> > that the addresses are only kept in the one place, and that we don't
> > need the mdesc nearly as early.
> >
> > The first change updates all of the addruart macros to return both
> > physical and virtual addresses. I've used 'rp' and 'rv' as the macro
> > arguments to indicate which address goes where
> >
> > The second change updates the debug setup routine to use the addruart
> > macro to establish the debug mapping, now that we can invoke the macro
> > to find the phyical and virtual addresses.
> >
> > This allows us to delay the requirement to have a mdesc available until
> > much later. For example, we can parse one from the device tree once
> > we've reached C code.
> >
> > May break OMAP1/2, as the addruart macros are more complex on these
> > platforms. I'd appreciate input from OMAP folks who may well tell me
> > that this isn't possible.
> >
> Just tried this on OMAP4, and indeed it breaks OMAP2PLUS low level debug
> support.
>
> Tony recently revamped the complete debug code, so that we can dynamically
> set correct debug port based on machine ID passed by boot-loaders. Based
> on this , the debug code determines the the correct debug port based on
> this using a scratch pad register.
>
> Tony can comment better on this issue.
Looks like the fix suggested by Jason Wang <jason77.wang@gmail.com>
is needed to make the mdesc series to work on omaps. An updated
version for the mdesc series is here:
http://marc.info/?l=linux-arm-kernel&m=128083927030188&w=2
So with the patch at the link above, the mdesc series
Tested-by: Tony Lindgren <tony@atomide.com>
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-03 12:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-31 9:25 Fwd: [PATCH 0/3] Allow late mdesc detection, v3 Russell King - ARM Linux
2010-07-31 12:45 ` Shilimkar, Santosh
2010-08-03 12:56 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2010-07-30 9:22 Jeremy Kerr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).