linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] USB-serial dummy cable driver
Date: Tue, 3 Aug 2010 18:14:15 +0200	[thread overview]
Message-ID: <201008031814.15859.marek.vasut@gmail.com> (raw)
In-Reply-To: <20100802224718.GC28821@suse.de>

Dne ?t 3. srpna 2010 00:47:18 Greg KH napsal(a):
> On Mon, Aug 02, 2010 at 08:00:07AM +0200, Marek Vasut wrote:
> > This driver is used to implement USB-serial like behaviour over dummy
> > 
> > USB cables. These are used in the following devices:
> > 	Funsoft Serial USB driver
> > 	Genesys Logic GL620USB USB Laplink cable
> > 	HP4x (48/49) Serial cable
> > 	Motorola phones
> > 	Siemens USB-MPI Serial USB driver
> > 	ViVOpay USB Serial Driver
> > 	ZIO Motherboard USB driver
> 
> I like the idea, but not the name :)

Please don't expect miracles from me after 26 hours without sleep ;-)
> 
> Ideally, all of these would be able to be handled by the usb-serial
> generic driver directly.

I just noticed that one. Stupid me.
> 
> But really, having these multiple drivers is a good thing, they properly
> convey to the user what the device is, and it gives these developers and
> companies a sense of ownership over the code, and that matters at times.
> 
> So you lost the names of the devices with this patch, which isn't good.

Sheesh ... that's true, but having pile of copies of the same code is not good 
either. Can't we then just deprecate all these drivers and set correct udev 
rules?
> 
> It's my end-goal to move the usb-serial layer to be more like libata,
> where it is dirt-simple to make a new disk driver, only a few fields to
> fill in, what you want to override.  So, any work toward simplification
> of the generic layer would be appreciated to make these individual
> drivers even smaller in the end.
> 
> So don't delete them, but try to consolidate the code, or just make it
> so that it can be deleted, and you only need a simple module init/exit
> function that registeres a single structure, like libata.
> 
> Sound reasonable?

Sounds ok, I'd like to help you but I'm dead busy with a pile of ARM machines 
here. This hack was really just a side-job. I'll try looking into it if I wont 
get insane ;-)

Cheers
> 
> thanks,
> 
> greg k-h

  reply	other threads:[~2010-08-03 16:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-02  6:00 [PATCH] USB-serial dummy cable driver Marek Vasut
2010-08-02 22:47 ` Greg KH
2010-08-03 16:14   ` Marek Vasut [this message]
2010-08-03 16:38     ` Greg KH
2010-08-03 17:36       ` Marek Vasut
2010-08-03 17:49         ` Greg KH
2010-08-03 18:21           ` Marek Vasut
2010-08-03 18:37             ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008031814.15859.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).