From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [ARM] Introduce patching of phys_to_virt and vice versa
Date: Sun, 8 Aug 2010 23:24:02 +0100 [thread overview]
Message-ID: <20100808222402.GF23623@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.00.1008061256170.28809@xanadu.home>
On Fri, Aug 06, 2010 at 01:07:46PM -0400, Nicolas Pitre wrote:
> No idea. That depends how gcc is considering inline asm. Given there
> is one input operand, I suppose gcc would account for the delay slot
> before that operand is actually available.
For something which could very well become by default enabled across
the board - due to the push to have a single kernel binary for lots
of significantly different platforms - it seems little research has
been carried out on this point.
While I agree that other obvious solutions would be more expensive, I
think it makes sense to have the commit which is introducing this
method include a proper evaluation, not least so that people who need
to make the decision to enable this aren't repeating the same research
that someone else has done (or, worse, just decide to enable it 'just
because' without any understanding of what the effect may be.)
So, I'd be interested in hearing whether we do see any preceding ldr
delay slot scheduling for these asm instructions.
I think we also need to consider whether the volatile is really required.
This asm() doesn't have any side effects other than its output operand,
so I suspect that the volatile may get in the way of some optimisations
(such as deleting the operation if the output is not actually used.)
next prev parent reply other threads:[~2010-08-08 22:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-26 8:47 [PATCH] [ARM] Introduce patching of phys_to_virt and vice versa eric.miao at canonical.com
2010-06-26 8:50 ` Eric Miao
2010-06-26 9:54 ` Russell King - ARM Linux
2010-06-26 18:22 ` Nicolas Pitre
2010-07-02 15:06 ` Rob Herring
2010-07-20 21:16 ` Russell King - ARM Linux
2010-08-05 8:45 ` Eric Miao
2010-08-05 9:45 ` Russell King - ARM Linux
2010-08-05 13:01 ` Eric Miao
2010-08-06 17:11 ` Nicolas Pitre
2010-08-06 17:07 ` Nicolas Pitre
2010-08-08 22:24 ` Russell King - ARM Linux [this message]
2010-08-09 16:55 ` Nicolas Pitre
2010-09-28 13:35 ` Eric Miao
2010-09-28 17:51 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100808222402.GF23623@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).