* [PATCH] fix carelessly written Kconfig select statement
@ 2010-08-09 1:50 eric.y.miao at gmail.com
2010-08-09 7:39 ` Russell King - ARM Linux
0 siblings, 1 reply; 5+ messages in thread
From: eric.y.miao at gmail.com @ 2010-08-09 1:50 UTC (permalink / raw)
To: linux-arm-kernel
Any one found this?
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
---
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 232f0c7..684c1a1 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1184,8 +1184,8 @@ config LOCAL_TIMERS
REALVIEW_EB_A9MP || MACH_REALVIEW_PBX || ARCH_OMAP4 || \
ARCH_U8500 || ARCH_VEXPRESS_CA9X4 || ARCH_TEGRA)
default y
- select HAVE_ARM_TWD if (ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 || \\
- ARCH_U8500 || ARCH_TEGRA
+ select HAVE_ARM_TWD if (ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 || \
+ ARCH_U8500 || ARCH_TEGRA)
help
Enable support for local timers on SMP platforms, rather then the
legacy IPI broadcast method. Local timers allows the system
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] fix carelessly written Kconfig select statement
2010-08-09 1:50 [PATCH] fix carelessly written Kconfig select statement eric.y.miao at gmail.com
@ 2010-08-09 7:39 ` Russell King - ARM Linux
2010-08-11 8:10 ` Eric Miao
0 siblings, 1 reply; 5+ messages in thread
From: Russell King - ARM Linux @ 2010-08-09 7:39 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Aug 09, 2010 at 09:50:04AM +0800, eric.y.miao at gmail.com wrote:
> Any one found this?
>
> Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
> ---
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 232f0c7..684c1a1 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1184,8 +1184,8 @@ config LOCAL_TIMERS
> REALVIEW_EB_A9MP || MACH_REALVIEW_PBX || ARCH_OMAP4 || \
> ARCH_U8500 || ARCH_VEXPRESS_CA9X4 || ARCH_TEGRA)
> default y
> - select HAVE_ARM_TWD if (ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 || \\
> - ARCH_U8500 || ARCH_TEGRA
> + select HAVE_ARM_TWD if (ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 || \
> + ARCH_U8500 || ARCH_TEGRA)
Just get rid of the open paren - there's no reason for it to exist.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] fix carelessly written Kconfig select statement
2010-08-09 7:39 ` Russell King - ARM Linux
@ 2010-08-11 8:10 ` Eric Miao
2010-08-11 8:12 ` Russell King - ARM Linux
0 siblings, 1 reply; 5+ messages in thread
From: Eric Miao @ 2010-08-11 8:10 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Aug 9, 2010 at 3:39 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Mon, Aug 09, 2010 at 09:50:04AM +0800, eric.y.miao at gmail.com wrote:
>> Any one found this?
>>
>> Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>> ---
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 232f0c7..684c1a1 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1184,8 +1184,8 @@ config LOCAL_TIMERS
>> ? ? ? ? ? ? ? REALVIEW_EB_A9MP || MACH_REALVIEW_PBX || ARCH_OMAP4 || \
>> ? ? ? ? ? ? ? ARCH_U8500 || ARCH_VEXPRESS_CA9X4 || ARCH_TEGRA)
>> ? ? ? default y
>> - ? ? select HAVE_ARM_TWD if (ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 || \\
>> - ? ? ? ? ? ? ARCH_U8500 || ARCH_TEGRA
>> + ? ? select HAVE_ARM_TWD if (ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 || \
>> + ? ? ? ? ? ? ARCH_U8500 || ARCH_TEGRA)
>
> Just get rid of the open paren - there's no reason for it to exist.
>
Updated as below. Patch sent to your tracking system from kernel.org,
though not sure if it hits there or not.
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 232f0c7..5265884 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1184,7 +1184,7 @@ config LOCAL_TIMERS
REALVIEW_EB_A9MP || MACH_REALVIEW_PBX || ARCH_OMAP4 || \
ARCH_U8500 || ARCH_VEXPRESS_CA9X4 || ARCH_TEGRA)
default y
- select HAVE_ARM_TWD if (ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 ||
+ select HAVE_ARM_TWD if ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 || \
ARCH_U8500 || ARCH_TEGRA
help
Enable support for local timers on SMP platforms, rather then the
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] fix carelessly written Kconfig select statement
2010-08-11 8:10 ` Eric Miao
@ 2010-08-11 8:12 ` Russell King - ARM Linux
2010-08-11 8:27 ` Eric Miao
0 siblings, 1 reply; 5+ messages in thread
From: Russell King - ARM Linux @ 2010-08-11 8:12 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Aug 11, 2010 at 04:10:45PM +0800, Eric Miao wrote:
> On Mon, Aug 9, 2010 at 3:39 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Mon, Aug 09, 2010 at 09:50:04AM +0800, eric.y.miao at gmail.com wrote:
> >> Any one found this?
> >>
> >> Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
> >> ---
> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> >> index 232f0c7..684c1a1 100644
> >> --- a/arch/arm/Kconfig
> >> +++ b/arch/arm/Kconfig
> >> @@ -1184,8 +1184,8 @@ config LOCAL_TIMERS
> >> ? ? ? ? ? ? ? REALVIEW_EB_A9MP || MACH_REALVIEW_PBX || ARCH_OMAP4 || \
> >> ? ? ? ? ? ? ? ARCH_U8500 || ARCH_VEXPRESS_CA9X4 || ARCH_TEGRA)
> >> ? ? ? default y
> >> - ? ? select HAVE_ARM_TWD if (ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 || \\
> >> - ? ? ? ? ? ? ARCH_U8500 || ARCH_TEGRA
> >> + ? ? select HAVE_ARM_TWD if (ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 || \
> >> + ? ? ? ? ? ? ARCH_U8500 || ARCH_TEGRA)
> >
> > Just get rid of the open paren - there's no reason for it to exist.
> >
>
> Updated as below. Patch sent to your tracking system from kernel.org,
> though not sure if it hits there or not.
6th patch. :-p
Already fixed in my tree twice over and I'm waiting for Linus to pull it.
Thanks anyway.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] fix carelessly written Kconfig select statement
2010-08-11 8:12 ` Russell King - ARM Linux
@ 2010-08-11 8:27 ` Eric Miao
0 siblings, 0 replies; 5+ messages in thread
From: Eric Miao @ 2010-08-11 8:27 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Aug 11, 2010 at 4:12 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Wed, Aug 11, 2010 at 04:10:45PM +0800, Eric Miao wrote:
>> On Mon, Aug 9, 2010 at 3:39 PM, Russell King - ARM Linux
>> <linux@arm.linux.org.uk> wrote:
>> > On Mon, Aug 09, 2010 at 09:50:04AM +0800, eric.y.miao at gmail.com wrote:
>> >> Any one found this?
>> >>
>> >> Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>> >> ---
>> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> >> index 232f0c7..684c1a1 100644
>> >> --- a/arch/arm/Kconfig
>> >> +++ b/arch/arm/Kconfig
>> >> @@ -1184,8 +1184,8 @@ config LOCAL_TIMERS
>> >> ? ? ? ? ? ? ? REALVIEW_EB_A9MP || MACH_REALVIEW_PBX || ARCH_OMAP4 || \
>> >> ? ? ? ? ? ? ? ARCH_U8500 || ARCH_VEXPRESS_CA9X4 || ARCH_TEGRA)
>> >> ? ? ? default y
>> >> - ? ? select HAVE_ARM_TWD if (ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 || \\
>> >> - ? ? ? ? ? ? ARCH_U8500 || ARCH_TEGRA
>> >> + ? ? select HAVE_ARM_TWD if (ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_OMAP4 || \
>> >> + ? ? ? ? ? ? ARCH_U8500 || ARCH_TEGRA)
>> >
>> > Just get rid of the open paren - there's no reason for it to exist.
>> >
>>
>> Updated as below. Patch sent to your tracking system from kernel.org,
>> though not sure if it hits there or not.
>
> 6th patch. :-p
>
> Already fixed in my tree twice over and I'm waiting for Linus to pull it.
Good to know. No problem then.
>
> Thanks anyway.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-08-11 8:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-09 1:50 [PATCH] fix carelessly written Kconfig select statement eric.y.miao at gmail.com
2010-08-09 7:39 ` Russell King - ARM Linux
2010-08-11 8:10 ` Eric Miao
2010-08-11 8:12 ` Russell King - ARM Linux
2010-08-11 8:27 ` Eric Miao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).