linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/8] ARM i.MX: add SDMA driver
Date: Tue, 10 Aug 2010 09:15:38 +0200	[thread overview]
Message-ID: <20100810071538.GE27749@pengutronix.de> (raw)
In-Reply-To: <4C605150.7030403@gmail.com>

On Mon, Aug 09, 2010 at 09:04:48PM +0200, Magnus Lilja wrote:
> Hi Sascha,
> 
> Just some typos that I spotted.
> 
> > +struct sdma_state_registers {
> > +	u32 sf     : 1; /* source falut while loading data */
>                                   ^^^^^ typo?
> 
> > +	u32 unused0: 1;
> > +	u32 rpc    :14; /* return program counter */
> > +	u32 t      : 1; /* test bit:status of arithmetic & test instruction*/
> > +	u32 unused1: 1;
> > +	u32 pc     :14; /* program counter */
> > +	u32 lm     : 2; /* loop mode */
> > +	u32 epc    :14; /* loop end program counter */
> > +	u32 df     : 1; /* destiantion falut while storing data */
>                            ^^^^^^^^^^^^^^^^^ typos
> 
> > +	u32 unused2: 1;
> > +	u32 spc    :14; /* loop start program counter */
> > +};
> > +#else
> > +struct sdma_state_registers {
> > +	u32 pc     :14; /* program counter */
> > +	u32 unused1: 1;
> > +	u32 t      : 1; /* test bit: status of arithmetic & test instruction*/
> > +	u32 rpc    :14; /* return program counter */
> > +	u32 unused0: 1;
> > +	u32 sf     : 1; /* source falut while loading data */
>                                     ^^^ typo?

I'm glad I copied these typos from the fsl kernel and haven't invented
them myself. What the heck is a falut? fault?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2010-08-10  7:15 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-09  9:05 [RFC] SDMA support for i.MX Sascha Hauer
2010-08-09  9:05 ` [PATCH 1/8] ARM i.MX dma: implement wrapper for dma functions Sascha Hauer
2010-08-09 18:43   ` Magnus Lilja
2010-08-09 22:45   ` Linus Walleij
2010-08-10 12:34     ` Sascha Hauer
2010-08-09  9:05 ` [PATCH 2/8] ARM i.MX dma-mx1-mx2: use wrapper Sascha Hauer
2010-08-09 18:51   ` Magnus Lilja
2010-08-09 21:42     ` Sascha Hauer
2010-08-09  9:05 ` [PATCH 3/8] mxcmmc: use new dma api Sascha Hauer
2010-08-09  9:05 ` [PATCH 4/8] ARM i.MX: add SDMA driver Sascha Hauer
2010-08-09 19:04   ` Magnus Lilja
2010-08-10  7:15     ` Sascha Hauer [this message]
2010-08-10  9:20   ` Detlev Zundel
2010-08-10 13:46     ` Timur Tabi
2010-08-10 14:03       ` Lothar Waßmann
2010-08-10 14:08         ` Tabi Timur-B04825
2010-08-10 14:19           ` Detlev Zundel
2010-08-10 19:08   ` Uwe Kleine-König
2010-08-09  9:05 ` [PATCH 5/8] ARM i.MX3: Add sdma device Sascha Hauer
2010-08-09  9:05 ` [PATCH 6/8] ARM i.MX3: add dma request defines Sascha Hauer
2010-08-09 13:53   ` Uwe Kleine-König
2010-08-09  9:05 ` [PATCH 7/8] ARM i.MX3: add dma request resources to ssi/sdhc devices Sascha Hauer
2010-08-09  9:05 ` [PATCH 8/8] ASoC i.MX: switch to new DMA api Sascha Hauer
2010-08-10 13:21   ` Mark Brown
2010-08-09 18:38 ` [RFC] SDMA support for i.MX Magnus Lilja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100810071538.GE27749@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).