From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: COLIBRI PXA320: fix UCB1400 irq autoprobing
Date: Wed, 11 Aug 2010 23:25:55 +0200 [thread overview]
Message-ID: <201008112325.56019.marek.vasut@gmail.com> (raw)
In-Reply-To: <AANLkTinxeEbZqwdB=bzC=ZZFqk1iR28yv=ECYRFNeUE=@mail.gmail.com>
Dne St 11. srpna 2010 14:54:13 Yuri Ludkevich napsal(a):
> Ads properly initialization to GPIO4 ( alt. fn. #1, nCS3; because GPIO4 and
> GPIO4_2 cannot be
> configured as GPIO simultaneously ) so GPIO4_2 which used as irq line from
> UCB1400 may be
> detected while irq autoprobing routine.
>
> Signed-off by: Yuri Ludkevich <urx.forever@gmail.com>
> ---
>
> --- linux-next/arch/arm/mach-pxa/colibri-pxa320.c.orig 2010-08-11
> 16:01:46.000000000 +0400
> +++ linux-next/arch/arm/mach-pxa/colibri-pxa320.c 2010-08-11
> 16:23:30.000000000 +0400
> @@ -236,6 +236,19 @@ static void __init colibri_pxa320_init_u
> pxa3xx_mfp_config(ARRAY_AND_SIZE(colibri_pxa320_uart_pin_config));
> }
>
> +
> +static mfp_cfg_t colibri_pxa320_cpld_pin_config[] __initdata = {
> + /* init GPIO4 as nCS3 (AF1). If GPIO4 stay as GPIO
> + touchscreen irq (GPIO4_2 pin) autoprobing will not work.
> + See Marvell PXA320 datasheet for more details */
> + GPIO4_nCS3,
> +};
> +
> +static void __init colibri_pxa320_init_cpld(void)
> +{
> + pxa3xx_mfp_config(ARRAY_AND_SIZE(colibri_pxa320_cpld_pin_config));
> +}
> +
> void __init colibri_pxa320_init(void)
> {
> pxa_set_ffuart_info(NULL);
> @@ -252,6 +265,7 @@ void __init colibri_pxa320_init(void)
> mfp_to_gpio(MFP_PIN_GPIO28));
> colibri_pxa320_init_uart();
> colibri_pxa320_init_udc();
> + colibri_pxa320_init_cpld();
> }
>
> MACHINE_START(COLIBRI320, "Toradex Colibri PXA320")
Do we even have a touchscreen init routine on 320? Maybe you could supply us
with such a patch too?
Thanks :)
prev parent reply other threads:[~2010-08-11 21:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 12:54 [PATCH] ARM: COLIBRI PXA320: fix UCB1400 irq autoprobing Yuri Ludkevich
2010-08-11 14:33 ` Daniel Mack
2010-08-11 21:26 ` Marek Vasut
2010-08-12 11:48 ` Marek Vasut
2010-08-18 11:50 ` Daniel Mack
2010-08-20 8:34 ` Yuri Ludkevich
2010-08-20 9:34 ` Marek Vasut
2010-08-20 9:50 ` Daniel Mack
2010-08-11 21:25 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008112325.56019.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).