linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] OMAP3: PM: ensure IO wakeups are properly disabled
Date: Fri, 13 Aug 2010 11:02:00 +0300	[thread overview]
Message-ID: <20100813080200.18750.37791.stgit@baageli.muru.com> (raw)
In-Reply-To: <20100813080034.18750.15410.stgit@baageli.muru.com>

From: Kevin Hilman <khilman@ti.com>

Commit 5a5f561 (convert OMAP3 PRCM macros to the _SHIFT/_MASK suffixes)
mistakenly removed the check for PER when disabling the IO chain.

During idle, if the PER powerdomain transitions and CORE does not (as
is the case with the lower C-states when using CPUidle) the IO pad
wakeups are not being disabled in the idle path after they are
enabled.

This patch ensures that the check for disabling IO wakeups also checks
for PER transitions, matching the check done to enable IO wakeups.

Found when debugging PM/CPUidle related problems reported by Ameya
Palande <ameya.palande@nokia.com>.  Problems were triggered
particularily on boards with UART2 consoles (n900, Overo) since UART2
is in the PER powerdomain.

Tested on l-o master (omap3_defonfig + CONFIG_CPU_IDLE=y) as well
as with current PM branch.  Boards tested: n900, Overo, omap3evm.

Cc: Paul Walmsley <paul@pwsan.com>
Cc: Ameya Palande <ameya.palande@nokia.com>
Tested-by: Jarkko Nikula <jhnikula@gmail.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap2/pm34xx.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index fb4994a..7b03426 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -480,7 +480,9 @@ void omap_sram_idle(void)
 	}
 
 	/* Disable IO-PAD and IO-CHAIN wakeup */
-	if (omap3_has_io_wakeup() && core_next_state < PWRDM_POWER_ON) {
+	if (omap3_has_io_wakeup() &&
+	    (per_next_state < PWRDM_POWER_ON ||
+	     core_next_state < PWRDM_POWER_ON)) {
 		prm_clear_mod_reg_bits(OMAP3430_EN_IO_MASK, WKUP_MOD, PM_WKEN);
 		omap3_disable_io_chain();
 	}

  parent reply	other threads:[~2010-08-13  8:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-13  8:01 [PATCH 0/6] omap fixes for upcoming 2.6.36-rc1 Tony Lindgren
2010-08-13  8:01 ` [PATCH 1/6] omap3: id: fix 3630 rev detection Tony Lindgren
2010-08-13  8:01 ` [PATCH 2/6] OMAP3: Fix a cpu type check problem Tony Lindgren
2010-08-13  8:02 ` Tony Lindgren [this message]
2010-08-13  9:53   ` [PATCH 3/6] OMAP3: PM: ensure IO wakeups are properly disabled Sergei Shtylyov
2010-08-13 10:29     ` Tony Lindgren
2010-08-13 10:50       ` Sergei Shtylyov
2010-08-19 18:14         ` Kevin Hilman
2010-08-19 18:34           ` Sergei Shtylyov
2010-08-20  6:56             ` Tony Lindgren
2010-08-20 16:43               ` Kevin Hilman
2010-08-13  8:02 ` [PATCH 4/6] omap: Fix sev instruction usage for multi-omap Tony Lindgren
2010-08-13  9:04   ` Shilimkar, Santosh
2010-08-13  8:02 ` [PATCH 5/6] omap: Use CONFIG_SMP for test_for_ipi and test_for_ltirq Tony Lindgren
2010-08-13  9:04   ` Shilimkar, Santosh
2010-08-13  8:02 ` [PATCH 6/6] omap: Fix omap_4430sdp_defconfig for make oldconfig Tony Lindgren
2010-08-13  9:04   ` Shilimkar, Santosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100813080200.18750.37791.stgit@baageli.muru.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).