linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] ASoc: add machine driver for 88pm860x
Date: Fri, 13 Aug 2010 16:17:44 +0100	[thread overview]
Message-ID: <20100813151744.GD11661@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <AANLkTimWSCwUjE3Xw304DFGyP9VXXi_YT3R4fM_tvdm1@mail.gmail.com>

On Fri, Aug 13, 2010 at 11:01:36PM +0800, Haojian Zhuang wrote:
> On Fri, Aug 13, 2010 at 10:26 PM, Mark Brown

> >> From cd2063f68b233a86b24efa3f4dc3ca3c438b1576 Mon Sep 17 00:00:00 2001
> >> From: Haojian Zhuang <haojian.zhuang@marvell.com>
> >> Date: Thu, 12 Aug 2010 12:04:23 +0800

> > Please fix your configuration for sending patches - none of this header
> > stuff should be in the body of the mail.

> Oh. It seems wrong date. Do you know how to resolve this?

Using git send-email to send patches is the easiest thing, if you're
copying into the body of the message then just dropping this block from
the patch when you're pasting it in will usually do the trick.

> >> + ? ? SND_SOC_DAPM_SPK("Board Speaker", NULL),
> >> + ? ? SND_SOC_DAPM_MIC("Board Mic 1", NULL),
> >> + ? ? SND_SOC_DAPM_MIC("Board Mic 3", NULL),

> > What happened to Mic 2?

> Mic 2 is in headset. I declared it with "Mic Jack" in DAPM.

Ah, OK.  Might be clearer if you said something more like:

+ ? ? SND_SOC_DAPM_MIC("Board Mic 1", NULL),
+ ? ? SND_SOC_DAPM_MIC("Mic Jack", NULL),
+ ? ? SND_SOC_DAPM_MIC("Board Mic 3", NULL),

so it's easier to work out where the second jack went.

  reply	other threads:[~2010-08-13 15:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-13 13:55 [PATCH 5/5] ASoc: add machine driver for 88pm860x Haojian Zhuang
2010-08-13 14:26 ` Mark Brown
2010-08-13 15:01   ` Haojian Zhuang
2010-08-13 15:17     ` Mark Brown [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-08-12  4:04 Haojian Zhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100813151744.GD11661@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).