linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: 2.6.3[45] PCI regression (IXP4xx and PXA?)
Date: Fri, 13 Aug 2010 22:54:13 +0100	[thread overview]
Message-ID: <20100813215413.GA21607@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20100813152224H.fujita.tomonori@lab.ntt.co.jp>

On Fri, Aug 13, 2010 at 03:23:53PM +0900, FUJITA Tomonori wrote:
> On Wed, 11 Aug 2010 08:25:32 +0100
> Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> > It doesn't break dmabounce.
> > 
> > What it breaks is the fact that a PCI device which can do 32-bit DMA is
> > connected to a PCI bus which can only access the first 64MB of memory
> > through the host bridge, but the system has more than 64MB available.
> > 
> > Allowing a 32-bit DMA mask means that dmabounce can't detect that memory
> > above 64MB needs to be bounced to memory below the 64MB boundary.
> 
> But dmabounce doesn't look at dev->coherent_dma_mask.
> 
> The change breaks __dma_alloc_buffer()? If we set dev->coherent_dma_mask
> to DMA_BIT_MASK(32) for ixp4xx's pci devices, __dma_alloc_buffer()
> doesn't use GFP_DMA.

With an incorrect coherent_dma_mask, dma_alloc_coherent() will return
memory outside of the 64MB window.  This means that when dmabounce comes
to allocate the replacement buffer, it gets a buffer which won't be
accessible to the DMA controller - which is a condition it doesn't check
for.

Ergo, it breaks dmabounce.

  reply	other threads:[~2010-08-13 21:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-10 20:36 ARM: 2.6.3[45] PCI regression (IXP4xx and PXA?) Krzysztof Halasa
2010-08-11  2:06 ` FUJITA Tomonori
2010-08-11  7:25   ` Russell King - ARM Linux
2010-08-13  6:23     ` FUJITA Tomonori
2010-08-13 21:54       ` Russell King - ARM Linux [this message]
2010-08-14  9:30         ` FUJITA Tomonori
2010-08-14 18:46           ` Russell King - ARM Linux
2010-08-15  5:42             ` FUJITA Tomonori
2010-08-15  8:23               ` Russell King - ARM Linux
2010-08-15 15:55                 ` FUJITA Tomonori
2010-08-16 23:29           ` Krzysztof Halasa
2010-08-19  8:51             ` FUJITA Tomonori
2010-08-19 16:56               ` Krzysztof Halasa
2010-08-19 10:31           ` Benjamin Herrenschmidt
2010-08-19 14:50             ` FUJITA Tomonori
2010-08-19 16:53               ` Krzysztof Halasa
2010-08-19 17:20                 ` FUJITA Tomonori
2010-08-19 21:54                   ` Benjamin Herrenschmidt
2010-08-19 21:51               ` Benjamin Herrenschmidt
2010-08-26 11:55                 ` FUJITA Tomonori
2010-08-26 13:54                   ` FUJITA Tomonori
2010-08-26 17:57                     ` Russell King - ARM Linux
2010-08-27  6:54                       ` FUJITA Tomonori
2010-08-26 16:02                   ` Krzysztof Halasa
2010-08-27  0:26                     ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100813215413.GA21607@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).